Skip to content

Image block: Rename $p variable to $processor - #72033

Merged
cbravobernal merged 1 commit into
trunkfrom
rename/image-block-p-var-to-processor
Oct 2, 2025
Merged

Image block: Rename $p variable to $processor#72033
cbravobernal merged 1 commit into
trunkfrom
rename/image-block-p-var-to-processor

Conversation

@ockham

@ockham ockham commented Oct 2, 2025

Copy link
Copy Markdown
Contributor

What?

In the Image block's PHP code, rename the $p variable to $processor.

Why?

See #71893 (comment):

this looks like existing code, but it would be nice to rename $p here to $processor for consistency with other code in Core as example code.

How?

Simple replace.

Testing Instructions

Should be covered by unit and e2e tests. Some manual smoke testing of the Image block (on the frontend) won't hurt, though.

@ockham ockham self-assigned this Oct 2, 2025
@ockham ockham added [Type] Code Quality Issues or PRs that relate to code quality [Block] Image Affects the Image Block labels Oct 2, 2025

@fabiankaegy fabiankaegy left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍 All instances have been updated

@github-actions

github-actions Bot commented Oct 2, 2025

Copy link
Copy Markdown

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: ockham <bernhard-reiter@git.wordpress.org>
Co-authored-by: fabiankaegy <fabiankaegy@git.wordpress.org>
Co-authored-by: cbravobernal <cbravobernal@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@github-actions

github-actions Bot commented Oct 2, 2025

Copy link
Copy Markdown

Flaky tests detected in e656d4c.
Some tests passed with failed attempts. The failures may not be related to this commit but are still reported for visibility. See the documentation for more information.

🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/18192410273
📝 Reported issues:

@cbravobernal
cbravobernal enabled auto-merge (squash) October 2, 2025 12:39
@cbravobernal
cbravobernal merged commit 56a52ae into trunk Oct 2, 2025
80 of 81 checks passed
@cbravobernal
cbravobernal deleted the rename/image-block-p-var-to-processor branch October 2, 2025 12:40
@github-actions github-actions Bot added this to the Gutenberg 21.9 milestone Oct 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Block] Image Affects the Image Block [Type] Code Quality Issues or PRs that relate to code quality

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants