Data Bindings: Update terms data with markup content type - #71702
Closed
mikachan wants to merge 1 commit into
Closed
Data Bindings: Update terms data with markup content type#71702mikachan wants to merge 1 commit into
mikachan wants to merge 1 commit into
Conversation
mikachan
added
[Feature] Block bindings
[Block] Terms Query
|
Size Change: +76 B (0%) Total Size: 1.94 MB
ℹ️ View Unchanged
|
Contributor
|
To myself: update this PR with this future change: |
Member
Author
|
I don't think this is needed anymore as we've now created a Term Name block and a Term Count block, so I'll close this for now and we can always re-open if necessary. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Originally discussed in #71596, this tries adding a new data binding attribute for the terms data, "Name with Link", that uses a new type of attribute,
markup. This means we can combine data such as term name and link to create a link to a term.cc @cr0ybot
Why?
It's not currently possible to add a link format to a paragraph block, where the paragraph block is attached to a content attribute and the link is attached to a URL attribute. This PR allows us to combine these two pieces of data so that we're able to use both in the same block.
How?
Adds a new attribute, "Name with Link", and a new attribute parameter,
markup. The newmarkuptype can only be used oncontentattributes.Testing Instructions
Screenshots or screencast