Cherry Pick to 6.7: Preload: fix multiple regressions around global styles (#66468) - #66542
Merged
Conversation
Co-authored-by: ellatrix <ellatrix@git.wordpress.org> Co-authored-by: ramonjd <ramonopoly@git.wordpress.org> Co-authored-by: aaronrobertshaw <aaronrobertshaw@git.wordpress.org>
ramonjd
added
the
[Type] Regression
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
ramonjd
commented
Oct 29, 2024
|
Size Change: +24 B (0%) Total Size: 1.77 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in becaf41. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/11565629667
|
andrewserong
approved these changes
Oct 29, 2024
andrewserong
left a comment
andrewserong
left a comment
Contributor
There was a problem hiding this comment.
This is testing well for me in the post and site editors, thanks for backporting!
LGTM 🚀
aaronrobertshaw
approved these changes
Oct 29, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry picking #66468 to
wp/6.7Testing
Fire up this branch and head to the site editor.
Check that global-styles endpoints aren't fetched client side, but are, rather, preloaded via rest_preload_api_request
Do the same for the post editor.