Skip to content

Disable overriding links of images inside pattern instances #58660

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kevin940726 merged 4 commits into from
Feb 8, 2024
Merged

Disable overriding links of images inside pattern instances #58660

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f371556
Disable overriding links of images
kevin940726 Feb 5, 2024
9f17f14
Combine into existing useSelect
kevin940726 Feb 5, 2024
2d5b6f2
Separate into a different lockHrefControls
kevin940726 Feb 6, 2024
2063647
Address code review
kevin940726 Feb 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
47 changes: 28 additions & 19 deletions packages/block-library/src/image/image.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -405,6 +405,7 @@ export default function Image( {

const {
lockUrlControls = false,
lockHrefControls = false,
lockAltControls = false,
lockTitleControls = false,
} = useSelect(
Expand All @@ -413,19 +414,24 @@ export default function Image( {
return {};
}

const { getBlockBindingsSource } = unlock(
select( blockEditorStore )
);
const { getBlockBindingsSource, getBlockParentsByBlockName } =
unlock( select( blockEditorStore ) );
const {
url: urlBinding,
alt: altBinding,
title: titleBinding,
} = metadata?.bindings || {};
const hasParentPattern =
getBlockParentsByBlockName( clientId, 'core/block' ).length > 0;
return {
lockUrlControls:
!! urlBinding &&
getBlockBindingsSource( urlBinding?.source )
?.lockAttributesEditing === true,
lockHrefControls:
// Disable editing the link of the URL if the image is inside a pattern instance.
// This is a temporary solution until we support overriding the link on the frontend.
hasParentPattern,
lockAltControls:
!! altBinding &&
getBlockBindingsSource( altBinding?.source )
Expand All @@ -436,27 +442,30 @@ export default function Image( {
?.lockAttributesEditing === true,
};
},
[ isSingleSelected ]
[ clientId, isSingleSelected, metadata?.bindings ]
);

const controls = (
<>
<BlockControls group="block">
{ isSingleSelected && ! isEditingImage && ! lockUrlControls && (
<ImageURLInputUI
url={ href || '' }
onChangeUrl={ onSetHref }
linkDestination={ linkDestination }
mediaUrl={ ( image && image.source_url ) || url }
mediaLink={ image && image.link }
linkTarget={ linkTarget }
linkClass={ linkClass }
rel={ rel }
showLightboxSetting={ showLightboxSetting }
lightboxEnabled={ lightboxChecked }
onSetLightbox={ onSetLightbox }
/>
) }
{ isSingleSelected &&
! isEditingImage &&
! lockHrefControls &&
! lockUrlControls && (
<ImageURLInputUI
url={ href || '' }
onChangeUrl={ onSetHref }
linkDestination={ linkDestination }
mediaUrl={ ( image && image.source_url ) || url }
mediaLink={ image && image.link }
linkTarget={ linkTarget }
linkClass={ linkClass }
rel={ rel }
showLightboxSetting={ showLightboxSetting }
lightboxEnabled={ lightboxChecked }
onSetLightbox={ onSetLightbox }
/>
) }
{ allowCrop && (
<ToolbarButton
onClick={ () => setIsEditingImage( true ) }
Expand Down