[RNMobile] Ensure keyboard opens after requesting focus on Android - #57543
Merged
Conversation
This matches the behavior of the host app WP-Android.
geriux
approved these changes
Jan 4, 2024
geriux
left a comment
Member
There was a problem hiding this comment.
LGTM! Nice work on finding the culprit and applying a solution 🚀
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Ensure the keyboard always opens after the focus is requested in an Aztec view.
Why?
This issue was spotted while running the E2E tests that will be introduced in #57460. As far as we tested, seems to be only reproducible in the Android emulator. However, we decided to implement the fix to make the keyboard show logic more reliable.
How?
The function
showSoftKeyboardhas been updated with the following conditions:ℹ️ This approach has been based on this article.
Testing Instructions
Testing Instructions for Keyboard
N/A
Screenshots or screencast
N/A