Mobile: remove rich text multiline - #56117
Merged
Merged
Conversation
ellatrix
added
the
Mobile App - i.e. Android or iOS
|
Size Change: +8 B (0%) Total Size: 1.72 MB
ℹ️ View Unchanged
|
geriux
added
the
Mobile App - Automation
geriux
self-requested a review
November 22, 2023 11:39
geriux
approved these changes
Nov 22, 2023
geriux
left a comment
geriux
left a comment
Member
There was a problem hiding this comment.
LGTM! I've smoke-tested both platforms and the full E2E tests ran successfully 🚀
geriux
removed
the
Mobile App - Automation
ellatrix
force-pushed
the
remove/native-rich-text-multiline
branch
from
November 24, 2023 11:08
14c4a6d to
6b0edd8
Compare
ellatrix
enabled auto-merge (squash)
November 29, 2023 22:42
ellatrix
force-pushed
the
remove/native-rich-text-multiline
branch
from
December 7, 2023 22:09
6b0edd8 to
27ed5ed
Compare
|
Flaky tests detected in 27ed5ed. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/7134585178
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Multiline has long been deprecated (#42711). We can reuse the fallback logic for native as well (#54310).
Why?
Makes rich text a little easier to maintain.
How?
We don't use
multilinefor any block any longer, so it's safe to remove.Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast