RichText: remove __unstableOnSplitMiddle - #54183
Merged
Merged
Conversation
|
Size Change: -52 B (0%) Total Size: 1.51 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in b6dc284. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/6083019724
|
youknowriad
approved these changes
Sep 5, 2023
youknowriad
left a comment
youknowriad
left a comment
Contributor
There was a problem hiding this comment.
Agreed, this is very unlikely to impact anything.
mikachan
added
[Feature] Rich Text
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
This prop was splitting behaviour with multiline rich text. It seems safe to remove:
So this would only affect blocks that (1) are still using
multilineeven though it's deprecated, (2) are usingonSplitto allow block splitting on Enter/paste (uncommon for non core blocks) and (3) use the unstable__unstableOnSplitMiddleprop. We only ever used to this to improve writing flow for quote and list.Why?
Reduce the maintenance cost. I'm refactoring split behaviour and it's a pain to keep supporting it.
How?
Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast