Skip to content

Deprecate the data controls after all usages were updated - #26509

Merged
jsnajdr merged 1 commit into
masterfrom
deprecate/builtin-data-controls
Oct 28, 2020
Merged

Deprecate the data controls after all usages were updated#26509
jsnajdr merged 1 commit into
masterfrom
deprecate/builtin-data-controls

Conversation

@jsnajdr

@jsnajdr jsnajdr commented Oct 27, 2020

Copy link
Copy Markdown
Member

Marks the select, syncSelect and dispatch exports from @wordpress/data-controls as deprecated. Since #25362 they are built-in into every data store and don't need a separate package to work.

We needed to postpone the actual deprecation until all usages in Gutenberg monorepo packages were removed. That happened in #25993, #25990, #25949, #25773 and #25772. That work is now finished.

@jsnajdr jsnajdr added the [Package] Data Controls /packages/data-controls label Oct 27, 2020
@jsnajdr
jsnajdr requested review from nerrad and youknowriad October 27, 2020 14:57
@jsnajdr jsnajdr self-assigned this Oct 27, 2020
@github-actions

Copy link
Copy Markdown

Size Change: +92 B (0%)

Total Size: 1.2 MB

Filename Size Change
build/api-fetch/index.js 3.45 kB +3 B (0%)
build/block-editor/index.js 130 kB -2 B (0%)
build/block-library/index.js 145 kB -2 B (0%)
build/components/index.js 172 kB -3 B (0%)
build/data-controls/index.js 772 B +97 B (12%) ⚠️
build/data/index.js 8.77 kB +4 B (0%)
build/edit-navigation/index.js 11.2 kB -1 B
build/edit-site/index.js 21.9 kB -1 B
build/editor/index.js 43.1 kB -1 B
build/list-reusable-blocks/index.js 3.11 kB -1 B
build/server-side-render/index.js 2.77 kB -1 B
ℹ️ View Unchanged
Filename Size Change
build/a11y/index.js 1.14 kB 0 B
build/annotations/index.js 3.78 kB 0 B
build/autop/index.js 2.84 kB 0 B
build/blob/index.js 665 B 0 B
build/block-directory/index.js 8.72 kB 0 B
build/block-directory/style-rtl.css 943 B 0 B
build/block-directory/style.css 942 B 0 B
build/block-editor/style-rtl.css 11 kB 0 B
build/block-editor/style.css 11 kB 0 B
build/block-library/editor-rtl.css 8.93 kB 0 B
build/block-library/editor.css 8.93 kB 0 B
build/block-library/style-rtl.css 7.75 kB 0 B
build/block-library/style.css 7.75 kB 0 B
build/block-library/theme-rtl.css 741 B 0 B
build/block-library/theme.css 741 B 0 B
build/block-serialization-default-parser/index.js 1.88 kB 0 B
build/block-serialization-spec-parser/index.js 3.1 kB 0 B
build/blocks/index.js 48.1 kB 0 B
build/components/style-rtl.css 15.3 kB 0 B
build/components/style.css 15.3 kB 0 B
build/compose/index.js 9.81 kB 0 B
build/core-data/index.js 12.3 kB 0 B
build/date/index.js 31.8 kB 0 B
build/deprecated/index.js 768 B 0 B
build/dom-ready/index.js 571 B 0 B
build/dom/index.js 4.46 kB 0 B
build/edit-navigation/style-rtl.css 881 B 0 B
build/edit-navigation/style.css 885 B 0 B
build/edit-post/index.js 306 kB 0 B
build/edit-post/style-rtl.css 6.37 kB 0 B
build/edit-post/style.css 6.35 kB 0 B
build/edit-site/style-rtl.css 3.79 kB 0 B
build/edit-site/style.css 3.79 kB 0 B
build/edit-widgets/index.js 26.4 kB 0 B
build/edit-widgets/style-rtl.css 3.09 kB 0 B
build/edit-widgets/style.css 3.09 kB 0 B
build/editor/editor-styles-rtl.css 480 B 0 B
build/editor/editor-styles.css 482 B 0 B
build/editor/style-rtl.css 3.85 kB 0 B
build/editor/style.css 3.84 kB 0 B
build/element/index.js 4.65 kB 0 B
build/escape-html/index.js 735 B 0 B
build/format-library/index.js 7.7 kB 0 B
build/format-library/style-rtl.css 547 B 0 B
build/format-library/style.css 548 B 0 B
build/hooks/index.js 2.13 kB 0 B
build/html-entities/index.js 623 B 0 B
build/i18n/index.js 3.57 kB 0 B
build/is-shallow-equal/index.js 712 B 0 B
build/keyboard-shortcuts/index.js 2.52 kB 0 B
build/keycodes/index.js 1.94 kB 0 B
build/list-reusable-blocks/style-rtl.css 476 B 0 B
build/list-reusable-blocks/style.css 476 B 0 B
build/media-utils/index.js 5.34 kB 0 B
build/notices/index.js 1.79 kB 0 B
build/nux/index.js 3.42 kB 0 B
build/nux/style-rtl.css 671 B 0 B
build/nux/style.css 668 B 0 B
build/plugins/index.js 2.56 kB 0 B
build/primitives/index.js 1.43 kB 0 B
build/priority-queue/index.js 791 B 0 B
build/redux-routine/index.js 2.84 kB 0 B
build/reusable-blocks/index.js 3.06 kB 0 B
build/rich-text/index.js 13.2 kB 0 B
build/shortcode/index.js 1.69 kB 0 B
build/token-list/index.js 1.27 kB 0 B
build/url/index.js 4.06 kB 0 B
build/viewport/index.js 1.84 kB 0 B
build/warning/index.js 1.14 kB 0 B
build/wordcount/index.js 1.22 kB 0 B

compressed-size-action

@youknowriad youknowriad left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Package] Data Controls /packages/data-controls

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants