Spacer block: Allow 1px height and improve usability in the editor - #25464
Spacer block: Allow 1px height and improve usability in the editor#25464stokesman wants to merge 1 commit into
Conversation
|
@mapk I hope you don't mind, but I added you for review as I know you were involved in the original issue. This approach seems like it might be a reasonable trade-off. The downside that I pointed out in the issue is that the spacer size in the editor is no longer consistent with the post itself at sizes less than 20px because the block always has that minimum height in the editor. |
I agree here. While I understand some things just aren't going to be perfectly rendered in the Editor as they are on the front end, this particular block should. It is used to increase visual padding between elements and should reflect that padding accurately, IMO. I really dig the exploration here, but I think we need to keep iterating. |
67094f0 to
1d4307f
Compare
|
Closing as superseded by #25528, thanks for the exploration on this issue. ❤️ |
In order to fix #18906, this PR changes the minimum height of the spacer block to 1px and introduces a minimum height of
48px20px in the editor to ensure ease of block selection.EDIT: Reduced the minimum height to 20 pixels in the editor in accordance with the current minimum height and removed some margin that was a solution for inserter overlap that is tangential to this PR.
How has this been tested?
Wordpress v5.5.1 with Gutenberg plugin v9.0.0
Types of changes
Nonbreakers
Checklist: