Docs: Enhance Block Context documents - #25272
Merged
Merged
Conversation
atachibana
requested review from
ajitbohra,
chrisvanpatten and
mkaz
as code owners
September 12, 2020 16:53
Contributor
Author
|
@mkaz |
Member
|
Ok, that is weird, maybe I had the tabs open wrong, that comment was intended for #25299 |
mkaz
approved these changes
Sep 17, 2020
mkaz
left a comment
mkaz
left a comment
Member
There was a problem hiding this comment.
This looks good, I like the full example included at the bottom.
Thanks!
aristath
approved these changes
Sep 18, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@mkaz @aduth
This PR is enhancement of block context:
block.jsonby example source code for consistency and easiness.save. This is spec. See PR Block API: Add Block Context support #21467 though I spent whole hour to search here and there ...