Fix[Image Generation]: Detect support for connectors that authenticate without an API key (e.g. OAuth)#748
Open
diarmuidie wants to merge 1 commit into
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
has_image_generation_support() skipped connectors that authenticate without an API key (e.g. OAuth) because it only checked for API-key credentials. Also honor connectors the registry reports as configured, consistent with text generation credential detection. Add integration tests covering the API-key path, the non-API-key (configured) path, the missing-capability case, and the unauthenticated/unconfigured skip path.
fc4e693 to
73b28bf
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Follow up to #679.
has_image_generation_support()skipped connectors that authenticate without an API key (e.g. OAuth) because it only checked for API-key credentials. It now also honors connectors the AI client registry reports as configured.Why?
#679 gates the image generation UI on
has_image_generation_support(). That check relied solely onhas_connector_authentication(), which by design only detects API-key credentials (environment variable, constant, or stored option).As a result, a provider that is fully configured but authenticates via OAuth was never counted as supporting image generation, and the image generation UI stayed hidden even though the provider exposes an image-generation-capable model.
This mirrors how text generation credential detection already honors connectors that do not rely on API key settings.
How?
In the connector loop, a connector now qualifies when it either has API-key credentials or
is_connector_configured()reports it as configured through the registry:A
$reset_cacheparameter was added tohas_image_generation_support()so the per-request memoization can be recomputed (used by the new tests, and useful when connector configuration changes within a single request).Use of AI Tools
AI assistance: Yes
Tool(s): Claude Code
Model(s): Claude Opus 4.8
Used for: Investigating the regression, drafting the fix, and writing the integration tests; reviewed and edited by me.
Testing Instructions
Automated:
tests/Integration/Includes/HelpersTest.phpcovershas_image_generation_support()for the API-key path, the non-API-key (registry-configured) path, the missing-capability case, and the unauthenticated/unconfigured skip path.Manual:
Changelog Entry