UI: Standardize button sizing to 40px across all experiments#730
Closed
i-anubhav-anand wants to merge 41 commits into
Closed
UI: Standardize button sizing to 40px across all experiments#730i-anubhav-anand wants to merge 41 commits into
i-anubhav-anand wants to merge 41 commits into
Conversation
Developer - Bump `tmp` from 0.2.5 to 0.2.7 Co-authored-by: dkotter <dkotter@git.wordpress.org>
… Next/Previous in media modal (WordPress#631) Fixed - Alt Text Generation button becomes unresponsive after using Next/Previous in the media modal. Unlinked contributors: kohcsi. Co-authored-by: yogeshbhutkar <yogeshbhutkar@git.wordpress.org> Co-authored-by: jeffpaul <jeffpaul@git.wordpress.org> Co-authored-by: dkotter <dkotter@git.wordpress.org>
Developer - Bump `codecov/codecov-action` from 6.0.0 to 6.0.1 Co-authored-by: dkotter <dkotter@git.wordpress.org>
…WordPress#635) Developer - Bump `phpstan/php-8-stubs` from 0.4.34 to 0.4.35 and `phpstan/phpstan` from 2.1.54 to 2.1.55 Co-authored-by: dkotter <dkotter@git.wordpress.org>
…ess#605) Changed - Ensure the Editorial Notes and Editorial Updates controls stay grouped together in the post editor sidebar Co-authored-by: macayu17 <ayushhoff@git.wordpress.org> Co-authored-by: jeffpaul <jeffpaul@git.wordpress.org> Co-authored-by: dkotter <dkotter@git.wordpress.org>
…lorer (WordPress#642) Fixed - Added accessible labels to the provider and category filter dropdowns in the Abilities Explorer page. Co-authored-by: Trushiv04 <trushiv@git.wordpress.org> Co-authored-by: dkotter <dkotter@git.wordpress.org>
…ss on alt text (WordPress#645) Fixed - Lost focus when generating the alt text in image block inspector controls. Co-authored-by: hbhalodia <hbhalodia@git.wordpress.org> Co-authored-by: dkotter <dkotter@git.wordpress.org>
Fixed - Lost focus when toggling the connector approval state. Co-authored-by: hbhalodia <hbhalodia@git.wordpress.org> Co-authored-by: dkotter <dkotter@git.wordpress.org>
Fixed - Abilities Explorer schema validation. Co-authored-by: ekamran <ekamran@git.wordpress.org> Co-authored-by: dkotter <dkotter@git.wordpress.org>
…rdPress#644) Fixed - Lost focus after generating a title. Co-authored-by: hbhalodia <hbhalodia@git.wordpress.org> Co-authored-by: dkotter <dkotter@git.wordpress.org>
…trix (WordPress#637) Fixed - Add descriptive accessible labels to approval matrix toggle controls. Co-authored-by: ishitaj34 <ishitaj34@git.wordpress.org> Co-authored-by: Trushiv04 <trushiv@git.wordpress.org> Co-authored-by: dkotter <dkotter@git.wordpress.org>
…es Explorer (WordPress#649) Fixed - Added an accessible label to the ability test payload textarea in the Abilities Explorer. Co-authored-by: Trushiv04 <trushiv@git.wordpress.org> Co-authored-by: dkotter <dkotter@git.wordpress.org>
Fixed - Excerpt generation post context payload. Co-authored-by: ekamran <ekamran@git.wordpress.org> Co-authored-by: dkotter <dkotter@git.wordpress.org>
Changed - Return a consistent decorative flag from alt text generation results Co-authored-by: yusufhay <yusufmudagal@git.wordpress.org> Co-authored-by: dkotter <dkotter@git.wordpress.org>
Fixed - Clear out the meta description suggestion when the modal closes Co-authored-by: ekamran <ekamran@git.wordpress.org> Co-authored-by: dkotter <dkotter@git.wordpress.org>
Developer - Bump `phpstan/phpstan` from 2.1.55 to 2.2.1 Co-authored-by: dkotter <dkotter@git.wordpress.org>
…29dac8d2bf9a1e8493865fc97cd1c3c87b to 5e92f5e3c80d06126f22e83e4bb21221fbbd3e7f in the github-actions-updates group (WordPress#673) Developer - Bump `WordPress/action-wp-playground-pr-preview` to latest version Co-authored-by: dkotter <dkotter@git.wordpress.org>
Changed - Use explicit UTF-8 encoding for generated meta description character counts. Co-authored-by: yusufhay <yusufmudagal@git.wordpress.org> Co-authored-by: dkotter <dkotter@git.wordpress.org>
…ress#669) Fixed - Column reordering and hiding in the AI Request Logs table now persists instead of resetting to the default. Unlinked contributors: alexWinterjuice. Co-authored-by: Trushiv04 <trushiv@git.wordpress.org> Co-authored-by: dkotter <dkotter@git.wordpress.org> Co-authored-by: hbhalodia <hbhalodia@git.wordpress.org>
Fixed - UI inconsistency on AI Request Logs page. Co-authored-by: hbhalodia <hbhalodia@git.wordpress.org> Co-authored-by: dkotter <dkotter@git.wordpress.org>
Developer - Add `@WordPress/ai-maintainers` team. Co-authored-by: jeffpaul <jeffpaul@git.wordpress.org> Co-authored-by: dkotter <dkotter@git.wordpress.org>
…ent in AI Request Logs (WordPress#671) Fixed - Summary statistics showing zero for short time periods on non-UTC MySQL servers. Unlinked contributors: alexWinterjuice. Co-authored-by: prasadkarmalkar <prasadkarmalkar@git.wordpress.org> Co-authored-by: dkotter <dkotter@git.wordpress.org>
…ess#647) Fixed - Lost focus after generating images. Co-authored-by: yogeshbhutkar <yogeshbhutkar@git.wordpress.org> Co-authored-by: t-hamano <wildworks@git.wordpress.org> Co-authored-by: dkotter <dkotter@git.wordpress.org>
…(thoughtsTokenCount ignored) (WordPress#680) Fixed - Ensuring thinking tokens are counted in request logs. Co-authored-by: prasadkarmalkar <prasadkarmalkar@git.wordpress.org> Co-authored-by: dkotter <dkotter@git.wordpress.org> Co-authored-by: riccardodicurti <riccardodicurti@git.wordpress.org>
Added - Manual refresh button to the AI Request Logs table header. Co-authored-by: prasadkarmalkar <prasadkarmalkar@git.wordpress.org> Co-authored-by: pbearne <pbearne@git.wordpress.org> Co-authored-by: dkotter <dkotter@git.wordpress.org>
… suggestions (WordPress#663) Fixed - Lost focus after running content resizing actions. Co-authored-by: yogeshbhutkar <yogeshbhutkar@git.wordpress.org> Co-authored-by: dkotter <dkotter@git.wordpress.org>
…l in Alt_Text_Generation (WordPress#688) Fixed - Ensure the Ability schemas and outputs are valid JSON Schema for strict REST and MCP consumers. Co-authored-by: the-hercules <thehercules@git.wordpress.org> Co-authored-by: dkotter <dkotter@git.wordpress.org> Co-authored-by: WouterP0lman <wouterpolman@git.wordpress.org>
… template" off (normal editing mode), until reload (WordPress#694) Fixed - Title generation button disappears after toggling "Show template" off. Co-authored-by: hbhalodia <hbhalodia@git.wordpress.org> Co-authored-by: dkotter <dkotter@git.wordpress.org>
Developer - Clarify AI Connector provider setup. Co-authored-by: ekamran <ekamran@git.wordpress.org> Co-authored-by: jeffpaul <jeffpaul@git.wordpress.org>
Fixed - Prevent accidental interactions and stale feedback in the Meta Description generation modal and improve focus handling. Co-authored-by: yogeshbhutkar <yogeshbhutkar@git.wordpress.org> Co-authored-by: dkotter <dkotter@git.wordpress.org>
…ordPress#698) Fixed - Ensure focus isn't lost after generating an excerpt inline. Co-authored-by: Infinite-Null <ankitkumarshah@git.wordpress.org> Co-authored-by: dkotter <dkotter@git.wordpress.org>
Changed - Show an error message immediately in the image generation UI when there's no AI Connector in place that supports image generation. Co-authored-by: t-hamano <wildworks@git.wordpress.org> Co-authored-by: dkotter <dkotter@git.wordpress.org> Co-authored-by: mindctrl <mindctrl@git.wordpress.org>
…dPress#703) Developer - Removes the `ready_for_review` pull request event from the Test and Plugin Check GitHub Actions workflows. Co-authored-by: Infinite-Null <ankitkumarshah@git.wordpress.org> Co-authored-by: yogeshbhutkar <yogeshbhutkar@git.wordpress.org> Co-authored-by: dkotter <dkotter@git.wordpress.org>
…tions-updates group (WordPress#707) Developer - Bump `actions/checkout` from 6.0.2 to 6.0.3 Co-authored-by: justlevine <justlevine@git.wordpress.org> Co-authored-by: dkotter <dkotter@git.wordpress.org>
…plicate declarations. (WordPress#713) Fixed - Rename unforwarded `MaskCanvas` component function to `InnerMaskCanvas` to avoid duplicate declarations. Co-authored-by: justlevine <justlevine@git.wordpress.org> Co-authored-by: dkotter <dkotter@git.wordpress.org>
…#705) Fixed - AI Request Logs main header overlapping table header. Co-authored-by: Infinite-Null <ankitkumarshah@git.wordpress.org> Co-authored-by: dkotter <dkotter@git.wordpress.org>
Fixed - Allow users to clear an applied meta description while preventing whitespace-only descriptions. Co-authored-by: yogeshbhutkar <yogeshbhutkar@git.wordpress.org> Co-authored-by: dkotter <dkotter@git.wordpress.org>
Developer - Update NPM dev-deps. Co-authored-by: justlevine <justlevine@git.wordpress.org> Co-authored-by: dkotter <dkotter@git.wordpress.org>
…atus widget (WordPress#720) Changed - Use a neutral icon for disabled features and experiments in the AI Status widget. Unlinked contributors: i-anubhav-anand. Co-authored-by: ankitguptaindia <ankit-k-gupta@git.wordpress.org> Co-authored-by: dkotter <dkotter@git.wordpress.org>
…experiments Several Button components throughout the plugin were still rendering at the deprecated 36px height instead of the 40px standard. This applies the __next40pxDefaultSize prop to all primary/secondary/tertiary text buttons that were missing it, and enforces the prop via ESLint so new code stays consistent. Icon-only, compact, small, link, and toolbar buttons are intentionally excluded per the upstream Gutenberg convention. Fixes WordPress#701
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
…nt rule Pill accept/dismiss, title modal Regenerate/Insert, and image history nav arrows in both MediaLibraryImageEditor and shared/ImageHistoryNav were flagged by the @wordpress/components-no-missing-40px-size-prop rule added in this branch but not yet updated.
Collaborator
|
This PR is based against |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Closes #701
Add the
__next40pxDefaultSizeprop to allButtoncomponents that were missing it, and enforce it going forward via an ESLint rule.Why?
Several action buttons across the plugin were rendering at the deprecated 36px height while others were already at 40px, creating visible inconsistency. The Gutenberg component standard has designated 40px as the default and retired 36px (gutenberg#46734, gutenberg#46741).
How?
__next40pxDefaultSizeto all primary/secondary/tertiary textButtoncomponents that were missing it across 13 component files:src/experiments/content-resizing/components/ContentResizingToolbar.tsxsrc/experiments/meta-description/components/MetaDescriptionPanel.tsxsrc/experiments/meta-description/components/MetaDescriptionModal.tsxsrc/experiments/editorial-updates/components/EditorialUpdatesPlugin.tsxsrc/experiments/excerpt-generation/components/ExcerptGeneration.tsxsrc/experiments/alt-text-generation/components/AltTextControls.tsxsrc/experiments/alt-text-generation/components/MediaEditorAltTextControl.tsxsrc/experiments/connector-approval/components/PendingRequestsCard.tsxsrc/admin/ai-request-logs/components/SettingsPanel.tsxsrc/features/image-generation/components/GenerateImageStandalone.tsxsrc/features/image-generation/components/GenerateImageInlineModal.tsxsrc/features/image-generation/components/MediaLibraryImageEditor.tsxsrc/features/image-generation/components/shared/index.tsxsize="compact",size="small",variant="link", andToolbarButtoninstances are intentionally excluded per upstream convention.'@wordpress/components-no-missing-40px-size-prop': 'error'toeslint.config.mjsto prevent regression.Use of AI Tools
AI assistance: Yes
Tool(s): Claude Code
Model(s): claude-sonnet-4-6
Used for: Implementation assistance; code reviewed and verified by me.
Testing Instructions
npm run lint:js— should pass with no new violations.Screenshots or screencast
Changelog Entry