Code Quality: Remove any type assertions from notices store dispatches#725
Merged
Merged
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
yogeshbhutkar
force-pushed
the
fix/remove-any-types
branch
from
3895af8 to
2669113
Compare
dkotter
approved these changes
Jun 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What, Why, and How?
This PR removes
anytype assertions around the notices store now that the upstream Gutenberg notices package has been converted to TypeScript in WordPress/gutenberg#67670.The current usage still treats these notice store dispatches as untyped, which hides useful TypeScript coverage and weakens editor DX. Using the package’s actual types makes the implementations clearer, improves autocomplete, and lets TypeScript catch incorrect notice usage earlier.
This PR intentionally keeps the scope limited to the notices package so the change is easier to review. If there is agreement on this direction, I’m happy to open a follow-up tracking issue for similar cleanup across other typed stores and packages.
Use of AI Tools
AI assistance: No
Changelog Entry