Fix: Load wp-dataviews translations on the AI Request Log page#723
Merged
dkotter merged 3 commits intoJun 17, 2026
Merged
Conversation
The @wordpress/dataviews component ships UI strings (filter chips, pagination, sort and view-options labels) that rely on WordPress core's default text domain. WordPress inlines those translations automatically in block-editor contexts, but not on standalone admin pages. This adds an explicit wp_set_script_translations() call for the wp-dataviews script so those strings are translated when the Request Log page is visited. Fixes WordPress#721
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
dkotter
approved these changes
Jun 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #721
What
Adds
wp_set_script_translations('wp-dataviews', 'default')toAI_Request_Log_Page::enqueue_assets().Why
The
@wordpress/dataviewspackage ships its own UI strings (column headers, search placeholder, pagination labels, etc.). WordPress only inlines those translations automatically on block-editor pages. On standalone admin pages like the AI Request Log, thewp-dataviewsscript handle was never registered for translation loading, so all DataViews UI text fell back to English regardless of the site language.How
wp_set_script_translations()hooks into the script-loader to attach the.po-derived JSON translation files for thewp-dataviewshandle — the same pattern used elsewhere in WordPress core for translatable packages.Testing
Use of AI Tools
GitHub Copilot and/or AI tooling was used to assist in drafting this contribution.