[issue #660] Add context-aware error message in Block Editor#686
[issue #660] Add context-aware error message in Block Editor#686AshishJii wants to merge 3 commits into
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Unlinked AccountsThe following contributors have not linked their GitHub and WordPress.org accounts: @ash@appla.local. Contributors, please read how to link your accounts to ensure your work is properly credited in WordPress releases. If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
dkotter
left a comment
There was a problem hiding this comment.
A couple things here:
- This only solves the issue for Title Generation. If we think this is worth having, this should be applied to all of our features
- Connector Approvals doesn't fire until the actual request is attempted whereas here, we're checking that much earlier. I think that's likely fine but does mean we now have two paths for the same feature
I would suggest we try and find a way that this can be applied easily to all features without having to duplicate the same code in each place. Maybe that's a pre-request hook each feature runs through that we can then use to run this? Or instead of duplicating the same Connector Approval code, maybe we hook in after the request has been blocked and update the error message?
What?
Closes #660
Implements a context-aware error message in the Block Editor's "Generate Title" flow when the AI connector is pending administrator authorization under the Connector Approvals screen.
Why?
Previously, when the Connector Approvals feature blocked the caller (
wp-ai), the user was shown a generic error message: "Title generation failed. Please ensure you have a connected provider that supports text generation."This led users to believe that their API keys or connected providers were broken when the feature was actually just awaiting approval in the WordPress admin panel.
Showing a clear, specific message helps the administrator locate and approve the pending connection under Tools > Connector Approvals.
How?
In
includes/Abilities/Title_Generation/Title_Generation.php:Approvals_StoreandCaller_Identifierexist.Approvals_Storefor any pending requests matching the caller's basename (wp-ai).$error_messagefrom the generic one to: "Title generation failed. The AI connector is currently pending authorization. Please approve the request under Tools > Connector Approvals."Use of AI Tools
AI assistance: Yes
Tool(s): Gemini
Model(s): Gemini 3.5 Flash
Used for: Writing the Pull Request description.
Testing Instructions
Screenshots or screencast
Changelog Entry