Repository navigation
Conversation
Rust 1.99 adds the pedantic clippy lint `assert_is_empty`, which this crate picks up through its blanket `pedantic = "warn"`, so `assert!(hashes.is_empty())` now fails CI's `-D warnings`. The lint's point is that a bare `assert!` prints nothing useful on failure; clippy's own suggestion is `assert_eq!(hashes, [] as [TxHash; 0])`, so a message carrying the value reads better and gives the same diagnostic. Verified on 1.99.0 with `cargo fmt --all -- --check` and `cargo clippy --all-targets --all-features -- -D warnings`. Closes V2-1399 Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
dirvine
approved these changes
Oct 1, 2026
dirvine
left a comment
Member
There was a problem hiding this comment.
Approved after focused review of head 1fee1b1548da36ecde0e692a1e5be9af7c8e1a80. No blocking findings.
Test-only diagnostic addition. The empty-hashes assertion predicate is unchanged; hashes are formatted only on failure. CI checks, including Clippy, tests and WASM portability, pass.
Review scope: full PR diff and relevant source/API semantics, live CI and review-thread inspection, plus one lightweight GLM-5.2 independent cross-check (no full panel). No local crate build/test run; execution evidence is GitHub CI.
jacderida
deleted the
chrisoneil/v2-1399-update-all-crates-for-the-new-rust-release
branch
October 1, 2026 20:14
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rust 1.99 (released 2026-09-28) adds the pedantic clippy lint
assert_is_empty, which this cratepicks up through its blanket
pedantic = { level = "warn" }. CI runs with-D warnings, soassert!(hashes.is_empty())inpayment::proof's tests now fails the clippy job — the same treepassed clippy on 1.98.1.
The lint's point is that a bare
assert!prints nothing useful when it fails; clippy's ownsuggestion is
assert_eq!(hashes, [] as [TxHash; 0]). A message carrying the value gives the samediagnostic and reads better in a test, so that is what this uses.
One of four PRs for V2-1399, which sweeps the new toolchain's lints across the crates; the others
are in
saorsa-transport,saorsa-coreandant-node. This repo had just the one site.Linear issue
Closes V2-1399
Risk tier
Test-only change: one assertion in a
#[cfg(test)]module gains a failure message.Compatibility
Semver impact
Test evidence
T0: repo CI only. Run on 1.99.0 (b940084d7, 2026-09-28), the toolchain that produced the failure:
cargo fmt --all -- --check— cleancargo clippy --all-targets --all-features -- -D warnings(the clippy job, verbatim) — cleancargo check --lib --no-default-features --target wasm32-unknown-unknownand the same with--features rpc(the WASM portability job) — cleanTest suites were not run locally; CI runs them on this PR. The assertion's condition is unchanged,
so
test_payment_proof_with_empty_tx_hashespasses or fails exactly as before.New dependency
none
ADR
n/a
Mitigation / rollback
Revert the commit.
🤖 Generated with Claude Code