feat(chart): add .Values.extraResources#322
Merged
choufraise merged 2 commits intoJun 9, 2026
Merged
Conversation
choufraise
requested changes
Jun 8, 2026
choufraise
left a comment
choufraise
left a comment
Collaborator
There was a problem hiding this comment.
Thanks for the contribution. This is a useful addition for the NAuth chart.
I’m good with the direction, but I’d like the review comments addressed before we merge. Once those are fixed, this should be straightforward to approve.
Collaborator
|
@madestreel , please also ensure that the commit(s) are signed-off (please see CONTRIBUTING.md) |
madestreel
force-pushed
the
feature/add-extra-resources
branch
7 times, most recently
from
570117a to
524fb0c
Compare
Author
|
@choufraise Hi, thanks for the suggestions. I did the required changes and signed the commits |
choufraise
approved these changes
Jun 9, 2026
Collaborator
|
@madestreel , sorry for the inconvenience, but may I please ask you to rebase this branch on top of |
madestreel
force-pushed
the
feature/add-extra-resources
branch
from
524fb0c to
358bb6f
Compare
added 2 commits
June 9, 2026 09:00
Signed-off-by: madestreel <maximedestreel@gmail.com>
Signed-off-by: madestreel <maximedestreel@gmail.com>
madestreel
force-pushed
the
feature/add-extra-resources
branch
from
358bb6f to
bc7722c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Goal is to allow users of the helm chart to deploy extra resources along nauth. This is useful to pre-configure a NatsCluster or run the operator-bootstrap within a job.