Repository navigation
fix(release): the installed proof reads people's next step from the top of the answer - #387
Merged
Merged
Conversation
…op of the answer Since #383 (cli-core 0.691.0, meetingAnswerBody) `meetings people --json` puts `next` beside `item`, not inside it. The installed proof unwrapped `item` first and read `people.next`, which is now undefined, so release run 44136465611 failed on every platform. Pull request CI does not run this proof, so #383 passed. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unblocks the 0.80.0 release. Release run 44136465611 failed on all six installed-package checks (Linux, macOS, Windows × Node 22/24) at
scripts/installed-platform.mjs:456:TypeError: Cannot read properties of undefined (reading '0'). Nothing was published.Why
#383 (cli-core 0.691.0,
meetingAnswerBody) movednextofmeetings people --jsonfromitemto the top of the answer. The installed proof'sanswer()helper returnspacket.item, sopeople.nextbecame undefined. Pull request CI does not run the installed-package proof (it runs only withpackor on a dispatch), so #383 passed.What
meetings peopleanswer and readsnextfrom its top level. The other reads ofnext/metain the installed scripts already use the raw answer.Testing
Locally on this branch:
pnpm build,npm pack, the tarball installed into a sandbox, thennode scripts/installed-platform.mjs <sandbox> 0.80.0: the whole proof passes (Linux, Node 24.19.0), including the MCP part after the fixed line, which the failed run never reached.🤖 Generated with Claude Code