Repository navigation
feat(account): notion <profile> account remove - #28
Merged
Merged
Conversation
…d forgets it WireCat Desktop removes an account with cli-core's account remove, and notion had only session end. The command forgets the token (token:<profile>), the profile's settings and its folder under the state directory (chosen pages, sync checkpoint, snapshots), and keeps or deletes the copied pages in the store. The token stays valid at Notion. Same hooks as ydisk-cli's account remove. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Task. The owner asked that every WireCat CLI can remove its accounts from Desktop. notion had only
session end, so Desktop's catalog hasremove: nullfor it.What.
notion <profile> account remove --keep-data|--delete-datathrough cli-core'saccountRemoveCommand, the same hooks as ydisk-cli: forgetstoken:<profile>and the profile's settings, removes its state folder (chosen pages, sync checkpoint, snapshots) with--delete-data, and keeps or deletes the copied pages in the store.profileDirinsrc/library.tsis now exported for it. Regenerateddocs/commands.mdandcontracts/wirecat.json. Changelog fragment under Added.Testing. New integration test in
src/library.test.ts: session start, sync, dry run changes nothing,--keep-datakeeps the pages and forgets the token,--delete-dataempties the store and removes the profile folder.pnpm test307 passed, typecheck, lint, docs check.🤖 Generated with Claude Code