Repository navigation
Conversation
The owner ruled against the alias (NEED-2759): WC-CMD-8 keeps no alias, for a path or its key. An old api.contacts-list in a config is now an unknown key again, so every command, mcp serve and config set refuse it, and the refusal names the new key to rename it to (api.contacts.list). serviceApiCommand marks its moved keys on the group; the unknown-key checks read them for the message. The alias check, its warning and its --dry-run entry are gone. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Task
Owner ruling NEED-2759 B: no exception to WC-CMD-8. An old flat api key (
api.contacts-list) in a config is refused with an error that names the new key (api.contacts.list), on the command line and over MCP. It is no longer checked as an alias, as #3141 did.Why
WC-CMD-8 keeps no alias for a moved path, its permission key included. A refusal is loud and never widens access, and the message says exactly what to rename.
What
serviceApiCommandmarks the moved keys on its group (markRenamedPermissionKeys). The old keys are no longer known keys: not inextra, not inalsoChecks, not checked by the guard, and no warning.mcp serve(configuration_error): "permissions.api.contacts-list names no command: its command moved, so rename it to permissions.api.contacts.list";mcp serve --permission api.contacts-list=deny;config set permissions.api.contacts-list deny(validation_error).changes/fix-api-old-keys-refused.mdunder "Changed — may break callers".Testing
service-api-groups.test.ts: an old key atdenyand atallowis refused on the command line;mcp servewith a saved old key and with--permission;config set; nothing is sent.vitest run src/cli src/mcp src/kit: 3354 pass. Plustypecheckanddocs:check.🤖 Generated with Claude Code