Skip to content

perf(store): purge a rebuild's old vectors through the hash index - #3118

Merged
leemour merged 2 commits into
mainfrom
perf/purge-vector-hashes
Nov 18, 2026
Merged

leemour merged 2 commits into
mainfrom
perf/purge-vector-hashes

Conversation

@leemour

@leemour leemour commented Nov 18, 2026 •

Copy link
Copy Markdown
Member

Task

After the linking-rules version became 6 (#3107), every user's chats get rebuilt. A rebuild of one large forum group
took about 15 minutes, most of it after the new build was already in place.

Why

purgeVectorHashes runs once per chunk text of the old build. Its candidates query joined on
chunks.chunkable_type, and SQLite chose the (chunkable_type, chunkable_id, position) index: every lookup read every
conversation chunk in the store instead of using chunks_by_content_hash. The delete after it named only
content_hash, while the embeddings key is (model, content_hash), so it read the whole key as well.

What

  • +k.chunkable_type keeps the planner on chunks_by_content_hash (checked with EXPLAIN QUERY PLAN).
  • The delete runs once per stored model, by the full key. The models are read once per purge.

Testing

🤖 Generated with Claude Code

leemour and others added 2 commits November 18, 2026 19:47
After a rebuild, purgeVectorHashes looks up each old chunk hash. Its
candidates query joined on chunks.chunkable_type, and SQLite picked the
(chunkable_type, chunkable_id, position) index, reading every conversation
chunk for each hash instead of using chunks_by_content_hash. The delete that
follows named only content_hash, while the embeddings key is
(model, content_hash), so it read the whole key too. Both now use their
index: `+k.chunkable_type` keeps the planner off the type index, and the
delete runs per model by the full key.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@leemour
leemour merged commit cfc56a2 into main Nov 18, 2026
44 checks passed
@leemour
leemour deleted the perf/purge-vector-hashes branch November 18, 2026 18:58
leemour added a commit to WireCatLabs/cli-testing that referenced this pull request Nov 18, 2026
… cli-core#3118 (#384)

## Task
Record the measurement behind
[WireCatLabs/cli-core#3118](WireCatLabs/cli-core#3118).

## Why
cli-core's linking-rules version 6 (#3107) rebuilds every user's
conversations, and on a test store one forum
rebuild spent most of its time dropping the old build's vectors.

## What
- `performance/store/vector-purge/README.md`: why it was run, setup,
results, what it showed, what was not measured.
  Totals only: the store is a private copy.
- `performance/store/vector-purge/bench.mjs`: times the purge's two
lookups read-only on any store, before and after,
  with their query plans.
- Linked from `performance/store/README.md`.

Headline: the forum rebuild went from 889 s (twice) to 52 s; the
candidates lookup from about 20 ms to 0.13 ms per old
chunk text.

## Testing
Biome, markdownlint and `pnpm docs:check`; `bench.mjs` run on the test
store.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant