Repository navigation
fix(cli): the api group tells Basic by its scheme, so a newer cli-base cannot change who signs - #3104
Merged
Merged
Conversation
…e cannot change who signs cli-base #643 makes signInPlace sign Basic. authOf told Basic apart by signInPlace answering undefined, so with that cli-base a call offering Basic and a token was signed with Basic, and a token without a user name went out in base64 instead of being refused with "run session start --login <name>". authOf now decides by the scheme's type and keeps its own Basic place with the colon check, so both rules hold with either cli-base. A test mocks a cli-base that signs Basic; it fails on main (Basic instead of Bearer) and passes here. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
leemour
added a commit
that referenced
this pull request
Nov 18, 2026
…in (#3106) ## Task The single cli-core release (carrying #3102, #3103, #3104) pins cli-base 0.117.0, which has #642, #643 (Basic sign-in, which #3104 handles) and #644 (the tracker nouns that let a tracker CLI pass `cli-dev lint`). ## What cli-base 0.117.0, the peer floor raised to it, STANDARD.md regenerated. ## Testing typecheck, docs:check, `src/tracker src/cli/service-api src/manifest` locally; the rest in CI (the disk is nearly full). 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
cli-base #643 (merged; it goes out in the next cli-base releases) makes
signInPlacesign HTTP Basic. cli-core'sauthOftold Basic apart bysignInPlaceansweringundefined. So a CLI that bumps cli-base while it stays on today's cli-core would:The next cli-core release must carry this fix before any CLI pins the new cli-base.
What
authOfdecides "Basic" by the scheme's type, not by whatsignInPlacereturns. It keeps its own Basic place with the colon check. Both rules now hold with the old and the new cli-base, and the code compiles against both.changes/fix-basic-auth-of.md.Testing
src/cli/service-api-basic.test.tsmocks a cli-base that signs Basic. It checks that the token scheme still goes first, that a token without:is refused, and thatuser:passwordis signed as Basic. On main it fails: Basic is sent instead of Bearer.profile-site.test.tspass.🤖 Generated with Claude Code