Repository navigation
fix(crm): a cleared value clears the copy, and the manifest fake takes a union's value - #3102
Merged
Merged
Conversation
…s a union's value
- map: a path past the end of a list or under a null the service sent is null, not
"not sent", so Attio's values.job_title.0.value on [] clears the stored position
- crmManifestFake builds a missing part of a mapped path from the union branch that has
the rest of the path; it wrote into the first branch and its strict fake refused the row
- auth.verify.active names where the token check says the token works (Attio answers a
dead token with 200 {"active": false}); valueAt is exported from cli-core/manifest
Found by the Attio pilot built from wirecat.config.ts (FIND-2748, FIND-2760, FIND-2761).
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
… path needs The first fix narrowed only a list the fake built itself; a row whose first sample already held the list (fixed value fields, an allOf) still carried the first branch. narrowed now steps through objects, open maps and allOf, and rowOf samples from the schema cut by every mapped path. A test covers fixed value fields and an each under null. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
leemour
added a commit
that referenced
this pull request
Nov 18, 2026
…in (#3106) ## Task The single cli-core release (carrying #3102, #3103, #3104) pins cli-base 0.117.0, which has #642, #643 (Basic sign-in, which #3104 handles) and #644 (the tracker nouns that let a tracker CLI pass `cli-dev lint`). ## What cli-base 0.117.0, the peer floor raised to it, STANDARD.md regenerated. ## Testing typecheck, docs:check, `src/tracker src/cli/service-api src/manifest` locally; the rest in CI (the disk is nearly full). 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Task
The Attio pilot (
attio-cli, built only fromwirecat.config.ts) runscrmSourceContractovercrmManifestFixture. Every case failed, and a value cleared in Attio stayed in the store.Why
crmManifestFakewrote a mapped value (values.name.0.full_name) into a sample of the union's first branch. Attio's values are aoneOfof 17 types, so the row matched none, and the strict fake refused its own answer.atreadvalues.job_title.0.valueon[]as "not sent", so the stored position stayed.GET /v2/selfanswers 200{ "active": false }to an unknown, revoked or deleted token; the config had no way to say so.What
allOf.at: past the end of a list, or under anullthe service sent, isnull. Watch for: aneachunder such anullgives[], so links clear too. A path the answer does not have still gives no key.auth.verify.active(type and strict schema) in@wirecat/cli-core/manifest;valueAtexported there. Nothing in cli-core readsactive: the template's session seed does (the coordinator's agent is on it).Reviewed by a fresh agent; its BUG-1 (a list the first sample already held kept the first branch) is fixed in the second commit, with a test.
Testing
vitest run src/crm src/manifest src/cli/service-api: 489 passed; lint, typecheck,docs:checkclean.cli-dev readyverified everywhere but the live check.Follow-up, not here:
src/cli/service-api-manifest.tskeeps its ownatfor page tokens (DEBT-367).🤖 Generated with Claude Code