Repository navigation
Conversation
WireCat Desktop could not sign out or remove an account of a tool it
installed from the npm manifest (beeline, hubspot, attio): its built-in
catalog has `accountRemove` for its own tools, the manifest never did.
`desktop.accountRemove` is now derived from the command tree, in the
exact shape Desktop's catalog uses (`AccountRemoveSource`):
- `signOut`: `{profile} session end --record --json` when the CLI has
`session end`;
- `remove`: `account remove --keep-data|--delete-data`, `--dry-run`,
`--yes`, `minVersion: "0.0.0"` (the manifest ships inside the version it
describes) when `account remove` takes the first three (`--yes` is cli-core's
global flag, so the command does not list it);
- `removes`/`keeps`: what the sign-out alone does, as the catalog writes
it for amo, bitrix and pbx; `[]` when there is no sign-out (zm).
The key is left out, not null, for a CLI with neither command or without
profiles: Desktop's `own_tools.rs` refuses a manifest with any key it does
not read, even a null one, so a null would break every CLI's next bump.
The last-sync query of a `<noun> sync` stays null: `runs list` matches
`command:` exactly, and the catalog's `command:"meetings sync"` holds a
space and quotes, which Desktop's plain-word check refuses in a manifest.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
leemour
marked this pull request as draft
November 18, 2026 18:41
`desktop.sync.last` was null for a `<noun> sync` such as beeline's `meetings sync`, so WireCat Desktop showed no last-sync time. `runs list` matches `command:` exactly, so a two-word command is found only as the quoted phrase. The manifest now writes it as one word, the form Desktop's catalog uses for zm and pbx: runs list 'command:"meetings sync" status:success' --limit 50 --no-record --json That word holds a space and quotes, so it is not a plain word. `SYNC_QUERY` allows exactly this form, and only in `sync.last`; every other array still takes plain words only. Desktop accepts the same form there (decided with the Desktop change that reads it). Checked on a built beeline in a throwaway HOME: the word returns the recorded `meetings sync` run with status success and not the failed one. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
WireCat Desktop cannot sign out or remove an account of a tool it installed from the npm manifest (beeline, hubspot, attio). Its built-in catalog has
accountRemovefor its own tools; the manifest never carried it.What
desktop.accountRemove, derived from the command tree in the exact shape of Desktop's catalog (AccountRemoveSource, wirecat-desktopsrc-tauri/src/account.rs):signOut:{profile} session end --record --jsonwhen the CLI hassession end.remove:{profile} account remove --keep-data|--delete-data --record --json,dryRun: "--dry-run",confirm: "--yes",minVersion: "0.0.0", whenaccount removetakes--keep-data,--delete-dataand--dry-run(--yesis cli-core's global flag).removes: ["signIn"],keeps: ["settings", "data", "listed"]as the catalog writes them for amo, bitrix and pbx;[]without a sign-out (zm).null, when the CLI has neither command or no profiles. Desktop'sown_tools.rsentry_ofrefuses anydesktopkey it does not read, even a null one.changes/fragment.Last sync for a
<noun> syncsync.lastwasnullformeetings sync, so Desktop showed no last-sync time.runs listmatchescommand:exactly (cli-coresrc/runs/run.ts:311), so it is now one quoted word, as the catalog writes it for zm and pbx:["runs","list","command:\"meetings sync\" status:success","--limit","50","--no-record","--json"]SYNC_QUERYallows exactly this form, and only insync.last. Desktop accepts the same form there in the change that readsaccountRemove.Do not release before Desktop reads the key and the query
Desktop 0.7.2 (and main today) has no
accountRemoveinown_tools.rsKEYS. A CLI that bumps to this version writes the key and Desktop refuses its manifest. Merge after the Desktop change that reads it ships.Testing
src/wcat/manifest.test.ts: full remove, sign-out only, remove only, neither.src/wcat/manifest.test.ts: the quotedlastof a noun sync; the query parses as a phrase; the schema takes it insync.lastonly and refuses near misses.runs list 'command:"meetings sync" status:success'returns the recorded success run and not the failed one.accountRemoveequals amo's catalog entry. The words run against a throwaway profile (DBUS_SESSION_BUS_ADDRESS=disabled:, temp HOME): no unknown option.🤖 Generated with Claude Code