Repository navigation
fix(codegen): additionalProperties true or {} keeps an object open - #649
Merged
Merged
Conversation
adaptOpenApi dropped an empty additionalProperties, so fakeApi refused every field of an object the spec leaves open, such as Attio's records filter and its $or, as "no such field". It is now kept as any value. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Attio's spec gives the records query
filteras{type: object, additionalProperties: true}.adaptOpenApidropped that, sofakeApirefusedfilter.$oras "no such field". attio-cli's test ofpeople list <words>could not run against the strict fake.What
additionalProperties: trueor{}becomesadditionalProperties: {type: unknown}. A closed object (false) or one that says nothing stays as before. Generated types for such objects gain an index signature.Testing
vitest run src/codegen(163 passed), lint, typecheck, docs:check.🤖 Generated with Claude Code