Repository navigation
fix(calls): transcribe recordings a telephony provider keeps; --max-meetings counts calls with a recording - #148
Merged
Merged
Conversation
…eetings counts calls with a recording A portal with an outside telephony provider (a Beeline cloud PBX, seen live on 2026-11-17) gives each call's CALL_RECORD_URL on the provider's own host. b24 followed a download link only on the portal's origin, so meetings transcribe turned none of that portal's calls into text (reason bitrix.foreign-link). BitrixTransport.download now follows such a link only over https, only when every address the host resolves to is public (cli-core isPublicAddress), through hostFetch for that one host, with no redirect, with none of the portal's sign-in and outside the portal's pacer. The run record names only the host. userHosts names the provider's server. meetings transcribe --max-meetings promised "at most this many calls transcribed" but counted every call tried, those without a recording too, so when the newest calls had none, --max-meetings 1 turned nothing into text. A call with no recording is still listed under failed and no longer counts. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…n by its own test Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
leemour
added a commit
that referenced
this pull request
Nov 17, 2026
…extension (#149) A Beeline cloud PBX serves a call recording as application/octet-stream and names the file (.mp3) in Content-Disposition. b24 took the format from the type alone and refused it as recording.not-audio, so after #148 the download worked but no call of that portal was transcribed. When the type names no format (empty or octet-stream), the format comes from the Content-Disposition file name's extension, only one b24 already keeps (mp3, wav, ogg, m4a). Checked on the live portal before the push: one call, 89 s of audio, transcribed. Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Task
A live check on a real portal (2026-11-17) copied 391 calls and transcribed none:
CALL_RECORD_URLleads to the provider's own https host, not to the portal. b24 followed a download link only on the portal's origin (bitrix.foreign-link). One such link, probed by metadata only, answered 200 with no sign-in.meetings transcribe --max-meetings 1spent its one try on the newest call, which had no recording. The help promises "at most this many calls transcribed".The owner chose to follow the provider's links only over https, only to a public address, with no redirect and with no portal token.
What
BitrixTransport.download: a link off the portal must be https. The host's every resolved address must pass cli-core'sisPublicAddress(a literal IP is checked as written). It is fetched throughhostFetchfor that one host, with no redirect, with nothing of the sign-in, and outside the portal's pacer. The run record names only the host. A refusal keeps the reasonbitrix.foreign-link, and its message never holds the link.meetings transcribe: a call with no recording is still listed underfailed(recording.missing) and no longer counts against--max-meetings.userHostsnames the provider's server.contracts/wirecat.jsonis regenerated.docs/calls.md(Recordings),docs/dev/DESIGN.md, and the fragmentchanges/fix-provider-recordings.md.Residual risk, written in DESIGN.md: the name is resolved once for the check and again by the request, so a host that changes its DNS answer in between is not caught. cli-core's
fetchPagepins the address but reads pages as text, so it does not fit a binary download.Testing
127.0.0.1, a private address and a mixed public+private answer before any request.calls.test.ts: sync refuses a link into a private network; transcribe downloads from a provider host;--max-meetings 1transcribes the older call with a recording past two newer ones without. All 4 fail without the fix.pnpm test580/580, typecheck, lint, docs:check, contracts:check, generate:check, standards:check.🤖 Generated with Claude Code