Skip to content

fix(calls): transcribe recordings a telephony provider keeps; --max-meetings counts calls with a recording - #148

Merged
leemour merged 2 commits into
mainfrom
fix/provider-recordings
Nov 17, 2026
Merged

leemour merged 2 commits into
mainfrom
fix/provider-recordings

Conversation

@leemour

@leemour leemour commented Nov 17, 2026

Copy link
Copy Markdown
Member

Task

A live check on a real portal (2026-11-17) copied 391 calls and transcribed none:

  1. That portal's telephony is a Beeline cloud PBX. Each CALL_RECORD_URL leads to the provider's own https host, not to the portal. b24 followed a download link only on the portal's origin (bitrix.foreign-link). One such link, probed by metadata only, answered 200 with no sign-in.
  2. meetings transcribe --max-meetings 1 spent its one try on the newest call, which had no recording. The help promises "at most this many calls transcribed".

The owner chose to follow the provider's links only over https, only to a public address, with no redirect and with no portal token.

What

  • BitrixTransport.download: a link off the portal must be https. The host's every resolved address must pass cli-core's isPublicAddress (a literal IP is checked as written). It is fetched through hostFetch for that one host, with no redirect, with nothing of the sign-in, and outside the portal's pacer. The run record names only the host. A refusal keeps the reason bitrix.foreign-link, and its message never holds the link.
  • meetings transcribe: a call with no recording is still listed under failed (recording.missing) and no longer counts against --max-meetings.
  • userHosts names the provider's server. contracts/wirecat.json is regenerated.
  • docs/calls.md (Recordings), docs/dev/DESIGN.md, and the fragment changes/fix-provider-recordings.md.

Residual risk, written in DESIGN.md: the name is resolved once for the check and again by the request, so a host that changes its DNS answer in between is not caught. cli-core's fetchPage pins the address but reads pages as text, so it does not fit a binary download.

Testing

  • New: transport follows a public provider host (no portal secret, run record without the path) and refuses http, 127.0.0.1, a private address and a mixed public+private answer before any request. calls.test.ts: sync refuses a link into a private network; transcribe downloads from a provider host; --max-meetings 1 transcribes the older call with a recording past two newer ones without. All 4 fail without the fix.
  • pnpm test 580/580, typecheck, lint, docs:check, contracts:check, generate:check, standards:check.

🤖 Generated with Claude Code

leemour and others added 2 commits November 17, 2026 22:40
…eetings counts calls with a recording

A portal with an outside telephony provider (a Beeline cloud PBX, seen live on 2026-11-17) gives each call's
CALL_RECORD_URL on the provider's own host. b24 followed a download link only on the portal's origin, so
meetings transcribe turned none of that portal's calls into text (reason bitrix.foreign-link).

BitrixTransport.download now follows such a link only over https, only when every address the host resolves to
is public (cli-core isPublicAddress), through hostFetch for that one host, with no redirect, with none of the
portal's sign-in and outside the portal's pacer. The run record names only the host. userHosts names the
provider's server.

meetings transcribe --max-meetings promised "at most this many calls transcribed" but counted every call tried,
those without a recording too, so when the newest calls had none, --max-meetings 1 turned nothing into text.
A call with no recording is still listed under failed and no longer counts.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…n by its own test

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@leemour
leemour merged commit 863263b into main Nov 17, 2026
16 checks passed
@leemour
leemour deleted the fix/provider-recordings branch November 17, 2026 21:54
leemour added a commit that referenced this pull request Nov 17, 2026
…extension (#149)

A Beeline cloud PBX serves a call recording as application/octet-stream and names the file (.mp3) in
Content-Disposition. b24 took the format from the type alone and refused it as recording.not-audio, so after #148
the download worked but no call of that portal was transcribed.

When the type names no format (empty or octet-stream), the format comes from the Content-Disposition file name's
extension, only one b24 already keeps (mp3, wav, ogg, m4a). Checked on the live portal before the push: one call,
89 s of audio, transcribed.

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant