Repository navigation
fix(meetings): build on cli-core 0.663.0 and cli-base 0.100.0 - #28
Merged
Merged
Conversation
cli-core 0.663.0 makes the shared meetings commands page by the profile's defaults.limit, so addMeetingCommands and addMeetingSearchCommand now take pagingOf next to budgetOf. The meetings and events commands drop their own --json/--jsonl for the program's, so the test matrix loses those rows and the generated command reference follows. The meetings list example no longer passes the new default (--limit 20 → --limit 50), and a test holds that a bare meetings list pages by 20. cli-base 0.100.0 brings the one time grammar. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
cli-core's meetings show already answers { item, missing?, meta? }; beeline
wrapped it again, so --json printed item.item. bodyOf now passes core's item
through with its missing and meta. A test also holds that a bare
meetings list pages by the profile's configured defaults.limit.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
leemour
added a commit
that referenced
this pull request
Nov 14, 2026
bin/beeline-live nbzb on main after #28 (cli-core 0.663.0, cli-base 0.100.0), read-only, in a throwaway store: 254 calls synced with 0 warnings, one call transcribed. bin/release --local refused the older record because #27 and #28 changed src and the lockfile. Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
cli-core 0.663.0 (WireCatLabs/cli-core#2953) changed the shared meetings commands: they page by the profile's
defaults.limitand need the host to passpagingOf. beeline did not build against it.What
@wirecat/cli-core0.663.0 and@wirecat/cli-base0.100.0.pagingOftoaddMeetingCommandsandaddMeetingSearchCommand.meetings listexample uses--limit 50;--limit 20is now the default.--json/--jsonl, so their own rows leave the test matrix; regenerateddocs/commands.mdanddocs/dev/test-matrix.md.meetings show --jsonanswereditem.itemsince fix(meetings): build on cli-core 0.662.0; list and show read the store without a sign-in #27: core's show already answers{ item, missing, meta }.bodyOfpasses it through.meetings listpages by the profile's configureddefaults.limit(set to 2).changes/fix-review-followups.md.Testing
pnpm typecheck,pnpm lint,vitest run --maxWorkers=1(12 files, 127 tests),pnpm test:matrix:check,pnpm docs:check,pnpm contracts:check,pnpm lint:commands,pnpm generate:check,pnpm standards:check.🤖 Generated with Claude Code