Skip to content

fix(meetings): build on cli-core 0.663.0 and cli-base 0.100.0 - #28

Merged
leemour merged 2 commits into
mainfrom
fix/review-followups
Nov 14, 2026
Merged

leemour merged 2 commits into
mainfrom
fix/review-followups

Conversation

@leemour

@leemour leemour commented Nov 14, 2026 •

Copy link
Copy Markdown
Member

Why

cli-core 0.663.0 (WireCatLabs/cli-core#2953) changed the shared meetings commands: they page by the profile's defaults.limit and need the host to pass pagingOf. beeline did not build against it.

What

  • Pin @wirecat/cli-core 0.663.0 and @wirecat/cli-base 0.100.0.
  • Pass pagingOf to addMeetingCommands and addMeetingSearchCommand.
  • The meetings list example uses --limit 50; --limit 20 is now the default.
  • The meetings and events commands use the program's --json/--jsonl, so their own rows leave the test matrix; regenerated docs/commands.md and docs/dev/test-matrix.md.
  • meetings show --json answered item.item since fix(meetings): build on cli-core 0.662.0; list and show read the store without a sign-in #27: core's show already answers { item, missing, meta }. bodyOf passes it through.
  • A test holds that a bare meetings list pages by the profile's configured defaults.limit (set to 2).
  • Changelog fragment changes/fix-review-followups.md.

Testing

pnpm typecheck, pnpm lint, vitest run --maxWorkers=1 (12 files, 127 tests), pnpm test:matrix:check, pnpm docs:check, pnpm contracts:check, pnpm lint:commands, pnpm generate:check, pnpm standards:check.

🤖 Generated with Claude Code

cli-core 0.663.0 makes the shared meetings commands page by the profile's
defaults.limit, so addMeetingCommands and addMeetingSearchCommand now take
pagingOf next to budgetOf. The meetings and events commands drop their own
--json/--jsonl for the program's, so the test matrix loses those rows and
the generated command reference follows. The meetings list example no
longer passes the new default (--limit 20 → --limit 50), and a test holds
that a bare meetings list pages by 20.

cli-base 0.100.0 brings the one time grammar.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@socket-security

socket-security Bot commented Nov 14, 2026 •

Copy link
Copy Markdown

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Updated@​wirecat/​cli-base@​0.99.0 ⏵ 0.100.099 +1100100 +196 +170
Updated@​wirecat/​cli-core@​0.662.0 ⏵ 0.663.098 +1100100 +19670

View full report

cli-core's meetings show already answers { item, missing?, meta? }; beeline
wrapped it again, so --json printed item.item. bodyOf now passes core's item
through with its missing and meta. A test also holds that a bare
meetings list pages by the profile's configured defaults.limit.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@leemour
leemour merged commit abb4fc2 into main Nov 14, 2026
17 of 18 checks passed
@leemour
leemour deleted the fix/review-followups branch November 14, 2026 08:03
leemour added a commit that referenced this pull request Nov 14, 2026
bin/beeline-live nbzb on main after #28 (cli-core 0.663.0, cli-base 0.100.0), read-only, in a
throwaway store: 254 calls synced with 0 warnings, one call transcribed.
bin/release --local refused the older record because #27 and #28 changed src and the lockfile.

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant