Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions changes/chore-cli-core-0.662.0.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
### Changed — may break callers

- **A `readonly` level no longer stops `meetings sync`** (cli-core 0.662.0, was 0.656.0). A command that only fetches
call records into the local store runs at `readonly`; `deny` still refuses it. Commands that write the owner's
files or call another service stay blocked by `readonly`.
- **`meetings list` and `meetings show` take `--backend archive|server|both`** (cli-core 0.660.0). beeline does not
search Beeline from these commands, so both answer from the store. `meetings show` takes the call id, its
`meeting:` ref or Beeline's own id, and an id it does not know is `not_found`.
- **A shared config with a small slip is mended when it is read** (cli-core 0.659.0).
`~/.config/WireCat/config.json` with a byte-order mark, a comment, a trailing comma or a missing comma
between two lines is fixed in place, the old file kept beside it as `config.json.bak-<time>`.

### Fixed

- **`meetings list` and `meetings show` read the store without a sign-in.** They sign in only when a command fetches
from Beeline, so a profile that never signed in lists an empty store, as before.
9 changes: 5 additions & 4 deletions contracts/wirecat.json
Original file line number Diff line number Diff line change
Expand Up @@ -89,9 +89,9 @@
"meetings",
"list"
],
"summary": "stored meetings, newest first",
"summary": "meetings, newest first: the service's and the stored ones, kept in the store",
"effects": {
"remote": "none",
"remote": "read",
"local": "read"
},
"permission": "meetings.list",
Expand All @@ -102,9 +102,9 @@
"meetings",
"show"
],
"summary": "show a stored meeting",
"summary": "show a meeting, read again from the service with its people, transcript and…",
"effects": {
"remote": "none",
"remote": "read",
"local": "read"
},
"permission": "meetings.show",
Expand Down Expand Up @@ -525,6 +525,7 @@
"meeting": {
"fields": [
"id",
"provider_id",
"title",
"started_at",
"ended_at",
Expand Down
14 changes: 8 additions & 6 deletions docs/commands.md
Original file line number Diff line number Diff line change
Expand Up @@ -137,7 +137,7 @@ stored meetings and their records

### `beeline meetings list`

stored meetings, newest first
meetings, newest first: the service's and the stored ones, kept in the store

```sh
beeline meetings list [query] [options]
Expand All @@ -151,33 +151,35 @@ beeline meetings list [query] [options]
|---|---|
| `--json` | one JSON value. |
| `--jsonl` | one JSON object per item. |
| `--backend <archive\|server\|both>` | where to read: the store (archive), the service (server), or both, kept in the store (default: both). |
| `--limit <n>` | meetings per page. Default: `100`. |
| `--page <n>` | page number. Default: `1`. |

**Returns:** meeting — ref, id, provider, account, title, url, started_at, ended_at, and 8 more; every field: beeline commands info meetings list
**Returns:** meeting — ref, id, provider_id, provider, account, title, url, started_at, and 11 more; every field: beeline commands info meetings list

**Next usually:** `beeline meetings show <meeting>`, `beeline meetings transcript <meeting>`, `beeline meetings export <meeting>`

**Example:** `beeline work meetings list --limit 20 --json`

### `beeline meetings show`

show a stored meeting
show a meeting, read again from the service with its people, transcript and documents

```sh
beeline meetings show <meeting> [options]
```

| Argument | | What it is |
|---|---|---|
| `meeting` | required | stored call id, or the ref meetings list prints (meeting:1/375). |
| `meeting` | required | the stored meeting's number, its meeting: ref, or the service's id (provider_id). |

| Option | What it does |
|---|---|
| `--json` | one JSON value. |
| `--jsonl` | one JSON object per item. |
| `--backend <archive\|server\|both>` | where to read: the store (archive), the service (server), or both, kept in the store (default: both). |

**Returns:** meeting details — ref, id, provider, account, title, url, started_at, ended_at, and 17 more; every field: beeline commands info meetings show
**Returns:** meeting details — ref, id, provider_id, provider, account, title, url, started_at, and 20 more; every field: beeline commands info meetings show

**Next usually:** `beeline meetings transcript <meeting>`, `beeline meetings export <meeting>`

Expand Down Expand Up @@ -373,7 +375,7 @@ beeline search meetings <query> [options]
| `--project <project>` | meetings confirmed in this project, by name, key or alias. |
| `--tag <name>` | meetings with this tag, by name or alias. |
| `--topic-name <name>` | meetings with this topic, by name or alias. |
| `--since-time <time>` | meetings starting at or after this ISO 8601 date or time. |
| `--since-time <time>` | meetings starting at or after this ISO 8601 date or time, or 30m, 2h, 7d ago. |
| `--until-time <time>` | meetings starting at or before this ISO 8601 date or time; a date alone covers that whole local day. |
| `--limit <n>` | how many hits, 1 through 1000 (default 100). |
| `--cursor <cursor>` | continue from the previous page's page.next_cursor, with the same query and filters. |
Expand Down
4 changes: 3 additions & 1 deletion docs/dev/test-matrix.md
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ ran it · ⛔ not tested offline, with the reason and where it is checked instea
Measured from the test run (`coverage/argv.jsonl`), not searched for — see
[TESTING.md](TESTING.md) for how, and for the states and failures that cut across commands.

**82 ✅ · 70 ⛔ · 0 ❌** — 45 commands, 107 options.
**82 ✅ · 72 ⛔ · 0 ❌** — 45 commands, 109 options.

| Command | Option | | Note |
|---|---|---|---|
Expand All @@ -26,11 +26,13 @@ Measured from the test run (`coverage/argv.jsonl`), not searched for — see
| `meetings list` | | ✅ | |
| `meetings list` | `--json` | ✅ | |
| `meetings list` | `--jsonl` | ⛔ | cli-core's shared meetings command, tested in cli-core's src/meetings/cli; beeline supplies only the store and the call source (src/calls.test.ts) |
| `meetings list` | `--backend` | ⛔ | cli-core 0.660.0 src/store/meetings-read-through.test.ts drives archive, server and both on a shared source |
| `meetings list` | `--limit` | ✅ | |
| `meetings list` | `--page` | ⛔ | cli-core's shared meetings command, tested in cli-core's src/meetings/cli; beeline supplies only the store and the call source (src/calls.test.ts) |
| `meetings show` | | ✅ | |
| `meetings show` | `--json` | ✅ | |
| `meetings show` | `--jsonl` | ⛔ | cli-core's shared meetings command, tested in cli-core's src/meetings/cli; beeline supplies only the store and the call source (src/calls.test.ts) |
| `meetings show` | `--backend` | ⛔ | cli-core 0.660.0 src/store/meetings-read-through.test.ts drives archive, server and both on a shared source |
| `meetings transcript` | | ✅ | |
| `meetings transcript` | `--history` | ⛔ | cli-core's shared meetings command, tested in cli-core's src/meetings/cli; beeline supplies only the store and the call source (src/calls.test.ts) |
| `meetings transcript` | `--json` | ✅ | |
Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@
},
"dependencies": {
"@wirecat/cli-base": "0.99.0",
"@wirecat/cli-core": "0.656.0",
"@wirecat/cli-core": "0.662.0",
"commander": "15.0.0",
"valibot": "1.5.0"
},
Expand Down
10 changes: 5 additions & 5 deletions pnpm-lock.yaml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 6 additions & 0 deletions scripts/test-matrix-untested.ts
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,12 @@ const SHARED_MCP =
const SHARED_CORE = "cli-core's shared command or flag, tested in cli-core; beeline adds nothing to it"

export const UNTESTED: { command: string; option?: string; reason: string }[] = [
...["meetings list", "meetings show"].map((command) => ({
command,
option: "--backend",
reason:
"cli-core 0.660.0 src/store/meetings-read-through.test.ts drives archive, server and both on a shared source",
})),
{
command: "",
option: "--help-all",
Expand Down
5 changes: 3 additions & 2 deletions src/call-source.ts
Original file line number Diff line number Diff line change
Expand Up @@ -77,15 +77,16 @@ const participantsOf = (record: CallRecord): SourceParticipant[] => {
* Beeline call records as meetings for cli-core's `pull`. A record has no transcript, chat, summary or files of its
* own: Beeline offers none through the API (its records section lists, downloads and deletes, nothing more).
*/
export const callSource = (api: BeelineApi): MeetingSource => {
// Signs in on the first fetch: `meetings list` and `show` hold the source but read only the store (no find or get).
export const callSource = (api: () => BeelineApi): MeetingSource => {
const seen = new Map<string, CallRecord>()
return {
provider: PROVIDER_NAME,
name: "Beeline Cloud PBX",
overlapMs: OVERLAP_MS,
meetings: async (since) => {
const meetings = new Map<string, SourceMeeting>()
for await (const record of api.allRecords({ from: new Date(since) })) {
for await (const record of api().allRecords({ from: new Date(since) })) {
seen.set(record.id, record)
meetings.set(record.id, meetingOf(record))
}
Expand Down
5 changes: 3 additions & 2 deletions src/commands/meetings.ts
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,8 @@ const meetingId = (text: string): number => {
}
}

const TAKES_A_MEETING = ["meetings show", "meetings transcript", "meetings export"]
// cli-core's own `meetings show` reads the id, the ref and the service's id (0.660.0).
const TAKES_A_MEETING = ["meetings transcript", "meetings export"]
const UNUSED = new Set(["summary", "import"])

const acceptRef = (leaf: CommandType) => {
Expand Down Expand Up @@ -278,7 +279,7 @@ export const meetingsMount = () => {
env,
close,
api: signedIn,
source: () => (source ??= callSource(signedIn())),
source: () => (source ??= callSource(signedIn)),
}
},
}
Expand Down
1 change: 1 addition & 0 deletions src/sync-after-install.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ import { record } from "./testing/records.js"
describe("sync runs right after install, whatever the shared WireCat config holds", () => {
for (const one of syncAfterInstallCases({
sync: ["work", "meetings", "sync", "--since-time", "2026-10-01T00:00:00Z"],
profileLevels: { variable: "BEELINE_CONFIG_DIR", keys: ["meetings"] },
run: async (argv, env) => {
const err: string[] = []
const code = await run(argv, {
Expand Down
4 changes: 3 additions & 1 deletion src/transcribe-command.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -169,8 +169,10 @@ it("every command that takes a call takes the ref meetings list prints as well a
expect(byRef.code, `${command}: ${byRef.err}`).toBe(0)
expect(JSON.parse(byRef.out)).toEqual({ ...JSON.parse(byId.out), meta: expect.anything() })
}
const wrong = await ran(["work", "meetings", "show", "call-7", "--json"])
const wrong = await ran(["work", "meetings", "transcript", "call-7", "--json"])
expect(JSON.parse(wrong.err).error.message).toContain("meeting:1/375")
const unknown = await ran(["work", "meetings", "show", "call-7", "--json"])
expect(JSON.parse(unknown.err).error).toMatchObject({ code: "not_found" })
})

it("indexes what it transcribed, so a search that may not write finds it", async () => {
Expand Down
Loading