Repository navigation
feat(account): pbx <profile> account remove - #47
Merged
Merged
Conversation
…orgets it WireCat Desktop removes an account with cli-core's account remove, and pbx had only session end, so its account menu offered sign-out alone. The command forgets the saved database or SFTP password (token:<profile>) and the profile's settings, and keeps or deletes its calls in the store. The password stays valid on the server: pbx cannot revoke it. Same hooks as beeline-cli's account remove. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Task. The owner asked that every WireCat CLI can remove its accounts from Desktop (FIND-2786). pbx had only
session end.What.
pbx <profile> account remove --keep-data|--delete-datathrough cli-core'saccountRemoveCommand, the same hooks as beeline-cli: it forgetstoken:<profile>(the database or SFTP password) and the profile's settings, keeps or deletes the calls. Regenerateddocs/commands.md,contracts/wirecat.json, test matrix. Changelog fragment under Added, so the next release is a minor one.Testing. New integration test in
src/calls.test.ts: dry run lists the keyring entry and changes nothing,--keep-datakeeps the calls,--delete-dataempties the list.pnpm test191 passed, typecheck, lint,lint:commands,contracts:check,docs:check.Desktop's catalog still has
remove: nullfor pbx; it needsminVersionset to the release that ships this.🤖 Generated with Claude Code