Repository navigation
fix(transcribe): meetings transcribe answers the shared call_transcription_report shape - #42
Merged
Merged
Conversation
…ption_report shape beeline, b24 and pbx all answer `call_transcription_report`, and the family audit (WC-OUT-11) requires one schema per shared entity. b24 moved to beeline's shape in WireCatLabs/bitrix24-cli#145 after its old shape blocked beeline's pull requests; pbx had the same old shape and would block once on npm. Per WC-OUT-13 (durations in `_ms`, stored things named by `ref`): - `audio_ms` replaces the rounded `audio_seconds`; - each `failed` item has its `ref` (`meeting:<account>/<id>`); - a call with no recording is listed under `failed` as `recording.missing`, a reason pbx already declares; `without_recording` is gone. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Task
beeline, b24 and pbx answer the same
call_transcription_report. The family audit (same-entity-schema, WC-OUT-11) requires one shape. b24's old shape (the same as pbx's) blocked beeline's pull requests; b24 moved to beeline's shape in WireCatLabs/bitrix24-cli#145. pbx is not on npm yet, so the audit does not see it, but it would block once published.Why
WC-OUT-13: a length of time is milliseconds in a
_mskey, and a stored thing is named byref.What
audio_seconds(rounded)audio_msfailed[]meeting, reason, messagemeeting, ref, reason, messagewithout_recordingcountfailed[]withrecording.missing(already insrc/reasons.ts)Breaking for callers, so the fragment is under "Changed — may break callers". No release in this PR.
Testing
pnpm typecheck,pnpm lint, fullvitest run(190 passed),pnpm docs:check,pnpm contracts:check,pnpm generate:check.🤖 Generated with Claude Code