Conversation
Throwing an exception instead of replacing the given value with the maximum / minumum allowed in Vanilla commands Added configuration options for NachoSpigot commands
windcolor-dev
requested changes
Sep 19, 2026
windcolor-dev
left a comment
windcolor-dev
left a comment
Member
There was a problem hiding this comment.
Other than that, looks good!
| boolean conflicts = false; | ||
|
|
||
| if (!force && !enchantments.isEmpty()) { // TODO: Improve this to use a "hasEnchantments" call | ||
| if (!force && !item.hasEnchantments()) { |
Member
There was a problem hiding this comment.
It should be fine to keep this like how it was before.
I don't think a hasEnchantments method was added in newer API.
| boolean conflicts = false; | ||
|
|
||
| if (!force && !enchantments.isEmpty()) { // TODO: Improve this to use a "hasEnchantments" call | ||
| if (!force && !item.hasEnchantments()) { |
Member
There was a problem hiding this comment.
Suggested change
| if (!force && !item.hasEnchantments()) { | |
| if (!force && !enchantments.isEmpty()) { |
| return meta == null ? ImmutableMap.<Enchantment, Integer>of() : meta.getEnchants(); | ||
| } | ||
|
|
||
| // WindSpigot start |
Member
There was a problem hiding this comment.
Can remove this, same reason as above
Comment on lines
+407
to
+417
| // WindSpigot start | ||
| /** | ||
| * Checks if this ItemStack has any enchantments. | ||
| * | ||
| * @return True if this has any enchantments | ||
| */ | ||
| public boolean hasEnchantments() { | ||
| return !getEnchantments().isEmpty(); | ||
| } | ||
| // WindSpigot stop | ||
|
|
Member
There was a problem hiding this comment.
Suggested change
| // WindSpigot start | |
| /** | |
| * Checks if this ItemStack has any enchantments. | |
| * | |
| * @return True if this has any enchantments | |
| */ | |
| public boolean hasEnchantments() { | |
| return !getEnchantments().isEmpty(); | |
| } | |
| // WindSpigot stop |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added hasEnchantments method for better code style
Throwing an exception instead of replacing the given value with the maximum / minumum allowed in Vanilla commands
Added configuration options for NachoSpigot commands