Skip to content

zero-alloc ConcurrentIntHashMap - #176

Open
kalibrieren wants to merge 2 commits into
Wind-Development:masterfrom
Falchus:master
Open

kalibrieren wants to merge 2 commits into
Wind-Development:masterfrom
Falchus:master

Conversation

@kalibrieren

Copy link
Copy Markdown
Contributor

No description provided.

import static com.windpvp.windspigot.async.AsyncUtil.runSynchronized;

import net.minecraft.server.IntHashMap;
import net.minecraft.server.*;

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
import net.minecraft.server.*;
import net.minecraft.server.IntHashMap;

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's cleaner to use import net.minecraft.server.*; across the entire codebase as it's all piled up in net.minecraft.server anyways

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IDEs handle imports automatically, so I don't see a reason to intentionally switch to wildcard imports

I also think it's good practice to keep the diff minimal for each commit

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants