Repository navigation
Objective-C app targets: every header the project references - #34
Merged
Merged
Conversation
This was referenced Nov 6, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective-C app targets: every header the project references
Follow-up to #33. Past the
main.mfix, a bare React Native app whosemain.m,AppDelegate.handAppDelegate.mmare direct children of the Xcode project's main group (the app-named group holding only the asset catalog, Info.plist, launch screen and privacy manifest) failed compilingSources/App/AppMain.mwith'AppDelegate.h' file not found: rn-xtool copied only the headers of the Sources phase and of the group of the app folder (the folder ofINFOPLIST_FILE). Xcode has no such limit: its header map makes every header the project references importable as#import "X.h"from any source of the target. Not a release: the notes stay under[Unreleased].What users get
ios/is copied. The single-group rule is replaced by a walk of the whole group tree from the main group: each header (.h,.hpp) whose reference resolves underios/is copied toSources/App(keeping its path from the app folder, or fromios/when it is elsewhere:ios/AppDelegate.hlands atSources/App/AppDelegate.h) with its forward inSources/App/include. Left out: thePodsgroup (bypathorname) and anything underPods/,build/orDerivedData/, headers inside a.framework/.xcframework, the Products group, references in trees rn-xtool cannot place (BUILT_PRODUCTS_DIR,SDKROOT), and headers outsideios/(not copied, no error). Sources-phase headers come first, then those under the app folder, then the rest, so a header of the app folder keeps winning a name shared with another header; the existingℹ Two app headers are named X.hline reports such a clash.ℹ Skipped <path>: the Xcode project references this header, but the file does not exist, as Xcode builds until a source imports it. Before, a missing header of the app folder stopped the copy withMissing <path>.docs/bare-react-native.md, a troubleshooting entry keyed by'AppDelegate.h' file not found, and a CHANGELOG line under[Unreleased]→### Fixed.Verified
Sources/App/AppDelegate.hwithinclude/AppDelegate.hforwarding to it, next to amain.mimporting it; headers of other groups, with and without apath, and aSOURCE_ROOTheader are collected; headers of thePodsgroup (by path and by name), underPods/andbuild/, inside a.framework/.xcframeworkand in the Products group are not; headers outsideios/(relative, absolute,BUILT_PRODUCTS_DIR) are not collected and raise no error; the app-folder header case still passes; a referenced header missing on disk is skipped with theℹline and no forward.'AppDelegate.h' file not found, which this change addresses. A build with this change is pending on that app.Checks
npm test(2385 passed, 6 skipped) andnpm run lintpass.npm run scan:privateis clean on both commits.