feat(ssh): support YubiKey PIV through SSH agent - #2
Draft
WilliamWang1721 wants to merge 7 commits into
Draft
WilliamWang1721 wants to merge 7 commits into
WilliamWang1721 wants to merge 7 commits into
Conversation
github-actions
Bot
force-pushed
the
codex/yubikey-piv
branch
from
September 19, 2026 12:48
a7532cc to
e8ba1ff
Compare
github-actions
Bot
force-pushed
the
codex/yubikey-piv
branch
from
September 19, 2026 13:25
5133802 to
6fc3404
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Pebrel's built-in russh path did not use the current SSH agent, so a YubiKey PIV key loaded through PKCS#11 could not authenticate an in-app SSH session.
This intentionally keeps the change small:
Autoauthentication plan on Unix; signing stays in russh/the SSH agent;pebrel yubikey [--provider PATH]on macOS/Linux, loading Yubico'slibykcs11withssh-add -s;No new dependency, authentication mode, settings/UI state, PIN storage, key generation/import, persistent helper agent, defensive probe framework, or defensive test suite is introduced.
Validation
Branch:
codex/yubikey-pivFinal SHA:
6fc3404eb277422abeb1c92a907338bac724d1dcBase:
a95b6c6f86bc6b9781791ee2331b5373fa59560aExact-SHA validation run:
35445848364GitHub-hosted CI has no physical YubiKey attached, so PIN/touch hardware acceptance is not claimed as an automated test.
The branch is rebased on the current upstream
mainand is not behind it.