Add scan for inverter IDs setup option#935
Merged
Merged
Conversation
Co-Authored-By: Craig Dean <1908506+thargy@users.noreply.github.com>
Co-Authored-By: Craig Dean <1908506+thargy@users.noreply.github.com>
The attempt > self._scan_retries condition would never be checked.
Owner
Author
|
Still needs more testing. Some kind of UI feedback during the scan would be useful. Full scan takes such a long time that maybe we should remove that option and only offer scan 1-32 and manual config options. |
Owner
Author
|
Rename timeout to connect_timeout to distinguish the two.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds setup option to scan modbus addresses for inverters after entering host or IP and port in addition to the existing manual setup.
Scanning code contributed by @thargy