#1326 Persist Bulk Import table sorting across pages #1342
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I updated the Bulk Import table to carry carry the sorting across the entire list of encounters instead of just those visible in the current view. In doing this i created a custom sorting function to sort the entire list and save the state of the list so that it could be used for pagination while keeping the sorted order.
I also came across a bug related to the table's custom striping styling. When sorting by a column other than the table index, the color striping was not evenly distributed. I amended the custom striping styling to account for changes in index due to sorting, and changes in the rows per page variable to keep striping even.
PR fixes #1326