feat: bookmark a specific line or selection, not just a whole file - #90
Merged
Merged
Conversation
Adds a new "Bookmark Line/Selection" command (editor context menu + command palette) that captures the active editor's current line, or full selection when one spans multiple lines, alongside a bookmark. Opening such a bookmark reveals and re-selects that range. Whole-file bookmarks are unaffected, and the same file can now be bookmarked at multiple distinct line ranges (dedup now keys on uri + line range instead of uri alone). Closes #42.
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Bookmark Line/Selectioncommand (editor context menu + command palette) that bookmarks the active editor's current line, or the full range for a multi-line selection, instead of only the whole file.uri + lineStart + lineEndinstead ofurialone, so whole-file and line-scoped bookmarks for the same file can coexist.Closes #42.
Test plan
npm run lint(types + eslint)npm run format:checknpm run test(170 unit tests, 100% line coverage onextension.ts)npm run buildnpm run test:e2e(9 passing, including a new fixture-backed test covering add → tree display → open restores selection)