chore: propagate main into development - #106
Merged
Merged
Conversation
@playwright/test resolved to 1.63.0 after the dev-dep bump in d3ad36e, but the e2e job's pinned Playwright image was still v1.62.1-noble. The pre-baked chrome-headless-shell in that image doesn't match what 1.63.0 expects, so every spec failed with "Executable doesn't exist at /ms-playwright/chromium_headless_shell-1243/...". Realign the image tag with the package version. Claude-Session: https://claude.ai/code/session_01ERJte48V5qPtmRrpW8DgMS
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
The hardcoded image tag drifts the moment a Playwright dep bump lands on one branch but not the other: 7f38e0a set it to v1.63.0-noble to match development's lockfile, which then broke main's e2e (still on 1.62.1). Read the resolved @playwright/test version out of package-lock.json at run time and build the tag from it, so the pre-baked browsers always match the npm-installed client regardless of branch. Claude-Session: https://claude.ai/code/session_01ERJte48V5qPtmRrpW8DgMS
Wikid82
marked this pull request as ready for review
September 7, 2026 20:03
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automated PR carrying commits pushed directly to
main(hotfixes, CI-generatedcommits) down into
development. nightly is intentionally skipped — it picksthese up via the daily development sync instead.
Triggered by push 7f38e0a to main.