chore: propagate changes from main into development - #1338
Merged
Conversation
… branch The daily schedule / weekly workflow_call runs of toolchain-image.yml checked out the default branch (main) and computed the toolchain key from main's recipe, then compared it against main's Dockerfile pin. On main those always match, so open-bump-pr's 'did the pin move?' check was never true and no bot PR was opened — even though open-bump-pr targets 'base: development' and development accumulates its own Dockerfile ARG bumps (x/net, x/crypto, ...) that shift the toolchain key independently of main. Result: development-side toolchain-pin drift had no automated detection or repair path. It only surfaced when a main -> development propagation PR ran verify-toolchain-pin against the merge recipe (e.g. #1320/#1322), by which point the pin was already stale on the branch and no bot PR existed to fix it. Pin the build-toolchain, trivy-scan and open-bump-pr checkouts to 'development' on every non-pull_request trigger (schedule / workflow_dispatch / the weekly rebuild's workflow_call). pull_request runs keep the default merge-ref checkout. sync-pin-on-pr is unchanged (PR-only, already checks out the PR head; still guarded off for main/development/nightly/beta head refs). Claude-Session: https://claude.ai/code/session_01Jz4LgwfkxaF8E7TdAgk94y
Contributor
|
You are seeing this message because GitHub Code Scanning has recently been set up for this repository, or this pull request contains the workflow file for the Code Scanning tool. What Enabling Code Scanning Means:
For more information about GitHub Code Scanning, check out the documentation. |
Contributor
Author
✅ Supply Chain Verification Results✅ PASSED 📦 SBOM Summary
🔍 Vulnerability Scan
📎 Artifacts
Generated by Supply Chain Verification workflow • View Details |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automated PR to propagate changes from main into development.
Triggered by push to main.