ci: integration artifact retention + toolchain bump-bot commit prefix - #1308
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Contributor
|
You are seeing this message because GitHub Code Scanning has recently been set up for this repository, or this pull request contains the workflow file for the Code Scanning tool. What Enabling Code Scanning Means:
For more information about GitHub Code Scanning, check out the documentation. |
Contributor
✅ Supply Chain Verification Results✅ PASSED 📦 SBOM Summary
🔍 Vulnerability Scan
📎 Artifacts
Generated by Supply Chain Verification workflow • View Details |
1-day retention breaks "Re-run failed jobs" on a run older than 24h now that the suite jobs depend on the upstream build job's artifact instead of building the image themselves. 3 days covers realistic re-run windows at negligible cost. Claude-Session: https://claude.ai/code/session_01KXA4x9LrA2AsnLrvdHMZbS
Wikid82
force-pushed
the
ci/integration-artifact-retention-3d
branch
from
September 8, 2026 13:42
fecd881 to
f169740
Compare
The `open-bump-pr` job in toolchain-image.yml opened its daily digest-refresh PR with a `feat(security):` title and commit message. `feat:` makes release-please cut a minor release on every merge to `main`, so a routine toolchain-digest refresh was bumping the version each time. Switch the bot PR title and commit-message to `chore(docker): refresh bundled proxy toolchain image`, matching the sibling `sync-pin-on-pr` commit style (`chore(docker): sync toolchain image pin to …`). The `security` label is kept; only the conventional-commit prefix changes. Also updates docs/plans/current_spec.md so its bot-PR example and commit-convention note no longer contradict the workflow. Affects future bot PRs only. Claude-Session: https://claude.ai/code/session_01KXA4x9LrA2AsnLrvdHMZbS
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two small CI changes, both follow-ups to #1306 (integration-test consolidation, squash-merged as
255a23df).1.
ci: bump integration image artifact retention to 3 days(f1697408)Supervisor's non-blocking note on #1306. In
.github/workflows/integration-tests.yml, thecharon-integration-imageartifact retention goes 1 day → 3 days. The fan-out suitejobs (
cerberus/waf/rate-limit/crowdsec) no longer build the image themselves —they
docker loadit from thebuildjob's artifact — so a 1-day retention breaks GitHub's"Re-run failed jobs" once a run is >24h old. 3 days covers realistic re-run windows at
negligible cost. No behavior change beyond retention.
2.
ci: use chore prefix for the toolchain bump-bot commits and PRs(04233733)Maintainer request. The
open-bump-prjob in.github/workflows/toolchain-image.ymlopenedits daily digest-refresh PR with a
feat(security):title and commit message.feat:makesrelease-please cut a minor release on every merge to
main, so routine toolchain-digestrefreshes were bumping the version each time. Switched the bot PR title + commit-message to
chore(docker): refresh bundled proxy toolchain image(matching the siblingsync-pin-on-prstyle). The
securitylabel is retained; only the conventional-commit prefix changes.docs/plans/current_spec.mdupdated so its example + commit-convention note match.Affects future bot PRs only. Bot PR #1310 (already open with the old
feat(security):title) is being closed as a misfire.
Rebase note
Rebased onto
mainafter #1309 (fix(ci): restore toolchain pin on main …) landed, so theverify-toolchain-pin/merge-and-publishfailures inherited from the previously-brokenmainpin are resolved.