Skip to content

ci: integration artifact retention + toolchain bump-bot commit prefix - #1308

Merged
Wikid82 merged 2 commits into
mainfrom
ci/integration-artifact-retention-3d
Sep 8, 2026
Merged

Wikid82 merged 2 commits into
mainfrom
ci/integration-artifact-retention-3d

Conversation

@Wikid82

@Wikid82 Wikid82 commented Sep 8, 2026

Copy link
Copy Markdown
Owner

Two small CI changes, both follow-ups to #1306 (integration-test consolidation, squash-merged as 255a23df).

1. ci: bump integration image artifact retention to 3 days (f1697408)

Supervisor's non-blocking note on #1306. In .github/workflows/integration-tests.yml, the
charon-integration-image artifact retention goes 1 day → 3 days. The fan-out suite
jobs (cerberus / waf / rate-limit / crowdsec) no longer build the image themselves —
they docker load it from the build job's artifact — so a 1-day retention breaks GitHub's
"Re-run failed jobs" once a run is >24h old. 3 days covers realistic re-run windows at
negligible cost. No behavior change beyond retention.

2. ci: use chore prefix for the toolchain bump-bot commits and PRs (04233733)

Maintainer request. The open-bump-pr job in .github/workflows/toolchain-image.yml opened
its daily digest-refresh PR with a feat(security): title and commit message. feat: makes
release-please cut a minor release on every merge to main, so routine toolchain-digest
refreshes were bumping the version each time. Switched the bot PR title + commit-message to
chore(docker): refresh bundled proxy toolchain image (matching the sibling sync-pin-on-pr
style). The security label is retained; only the conventional-commit prefix changes.
docs/plans/current_spec.md updated so its example + commit-convention note match.

Affects future bot PRs only. Bot PR #1310 (already open with the old feat(security):
title) is being closed as a misfire.

Rebase note

Rebased onto main after #1309 (fix(ci): restore toolchain pin on main …) landed, so the
verify-toolchain-pin / merge-and-publish failures inherited from the previously-broken
main pin are resolved.

@codecov

codecov Bot commented Sep 8, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@github-advanced-security

Copy link
Copy Markdown
Contributor

You are seeing this message because GitHub Code Scanning has recently been set up for this repository, or this pull request contains the workflow file for the Code Scanning tool.

What Enabling Code Scanning Means:

  • The 'Security' tab will display more code scanning analysis results (e.g., for the default branch).
  • Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results.
  • You will be able to see the analysis results for the pull request's branch on this overview once the scans have completed and the checks have passed.

For more information about GitHub Code Scanning, check out the documentation.

@github-actions

github-actions Bot commented Sep 8, 2026

Copy link
Copy Markdown
Contributor

✅ Supply Chain Verification Results

PASSED

📦 SBOM Summary

  • Components: 1769

🔍 Vulnerability Scan

Severity Count
🔴 Critical 0
🟠 High 0
🟡 Medium 0
🟢 Low 0
Total 0

📎 Artifacts

  • SBOM (CycloneDX JSON) and Grype results available in workflow artifacts

Generated by Supply Chain Verification workflow • View Details

1-day retention breaks "Re-run failed jobs" on a run older than 24h now that
the suite jobs depend on the upstream build job's artifact instead of building
the image themselves. 3 days covers realistic re-run windows at negligible cost.

Claude-Session: https://claude.ai/code/session_01KXA4x9LrA2AsnLrvdHMZbS
@Wikid82
Wikid82 force-pushed the ci/integration-artifact-retention-3d branch from fecd881 to f169740 Compare September 8, 2026 13:42
The `open-bump-pr` job in toolchain-image.yml opened its daily
digest-refresh PR with a `feat(security):` title and commit message.
`feat:` makes release-please cut a minor release on every merge to
`main`, so a routine toolchain-digest refresh was bumping the version
each time. Switch the bot PR title and commit-message to
`chore(docker): refresh bundled proxy toolchain image`, matching the
sibling `sync-pin-on-pr` commit style (`chore(docker): sync toolchain
image pin to …`). The `security` label is kept; only the
conventional-commit prefix changes.

Also updates docs/plans/current_spec.md so its bot-PR example and
commit-convention note no longer contradict the workflow.

Affects future bot PRs only.

Claude-Session: https://claude.ai/code/session_01KXA4x9LrA2AsnLrvdHMZbS
@Wikid82 Wikid82 changed the title ci: bump integration image artifact retention to 3 days ci: integration artifact retention + toolchain bump-bot commit prefix Sep 8, 2026
@Wikid82
Wikid82 merged commit 8a93887 into main Sep 8, 2026
37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants