fix(deps): take cryptography to 50.0.0, the two fixable HIGH the gate blocks on - #431
Merged
Merged
Conversation
… blocks on `SCA — trivy (filesystem)` blocks on fixable HIGH, and the whole of what it finds in tracked files is two CVEs in one package: CVE-2026-69249 and CVE-2026-69247 against cryptography 48.0.1. 50.0.0 clears both, and re-running the gate's own invocation over requirements.txt reports zero. Scanning the working tree reports 496 findings, but 494 of them sit in local untracked directories that no CI checkout contains. Filtering to `git ls-files` is what makes the number match what the gate sees. PyJWT is the only dependent here. Verified on the image's Python (3.12, per ubuntu:24.04) rather than the host: cryptography 50.0.0 installs alongside PyJWT 2.13.0 and an RS256 sign/verify round-trip through a generated RSA key completes. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. 🗂️ Base branches to auto review (2)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clears the
SCA — trivy (filesystem)red on #346 (and inherited by #430).What the gate blocks on
The gate runs
severity: HIGH,exit-code: "1",ignore-unfixed: true— fixable HIGH only. Across tracked files that is exactly two CVEs, both in one package:Re-running the gate's own invocation over
requirements.txtafter the bump reports 0.Scope the scan with
git ls-filesbefore reading the number: an unfiltered working-tree scan also reports findings from untracked directories that no CI checkout contains, and those are not what the gate measures.Compatibility
48 → 50 crosses two majors, and the removals are real: 49.0.0 dropped the deprecated
PUBLIC_KEY_TYPES/PRIVATE_KEY_TYPES/CERTIFICATE_*_KEY_TYPESaliases, changed ChaCha20 nonce semantics, and rejects X.509 NULL-param signatures; 50.0.0 deprecates finite-field DH.No tracked
*.pyimportscryptographydirectly, and none of the removed surface is used.PyJWT==2.13.0is the only dependent, its own metadata iscryptography>=3.4.0with no upper bound, and no other tracked requirements file names cryptography or a dependent that pulls it — so the root pin is the only one to move.tests/test_requirements.pyasserts a lower bound of 46.0.6, which 50.0.0 satisfies.Verified on the image's Python (3.12, per
ubuntu:24.04) rather than the host, whose 3.14 fails the resolve on an unrelated package:cryptography==50.0.0andPyJWT==2.13.0install together and RS256 and ES256 sign/verify round-trips complete.One caveat
cryptography 49 dropped x86_64-macOS wheels. The image builds
linux/amd64andlinux/arm64, and 50.0.0 publishesmanylinux2014wheels for both (cp311-abi3, covering 3.12), so the image path is unaffected. A developer on an Intel Mac running a localpip installbuilds from sdist instead of getting a prebuilt wheel.The remaining Trivy alerts here are unfixable-HIGH or outside tracked files, so they fall outside what this gate blocks on.