Repository navigation
feat(security): restrict file attachments to attachments directory - #87
Merged
Merged
Conversation
dwickr
commented
Feb 10, 2026
dwickr
commented
Contributor
- Add path validation to prevent directory traversal attacks
- Create attachments directory on startup
- Add tests for valid and invalid attachment paths
- Refactor to use centralized userAttachmentsDir constant
- Add path validation to prevent directory traversal attacks - Create attachments directory on startup - Add tests for valid and invalid attachment paths - Refactor to use centralized userAttachmentsDir constant
dwickr
commented
Feb 10, 2026
| } | ||
|
|
||
| bot.setAdminOnly(false) | ||
| fs.mkdirSync(userAttachmentsDir, { recursive: true }) |
Contributor
Author
There was a problem hiding this comment.
We were previously doing this on every file upload, I moved it here to only run at startup.
bhrju
approved these changes
Feb 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.