Repository navigation
refactor: cleanup error messages, use consts - #86
Merged
Merged
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| .type('txt') | ||
| .status(404) | ||
| .send('Endpoint ' + req.url + ' not found') | ||
| return res.type('txt').status(404).send(`Endpoint ${req.url} not found`) |
Check failure
Code scanning / CodeQL
Reflected cross-site scripting High
Contributor
Author
There was a problem hiding this comment.
I dismissed this one. This is an API and the content type is text/plain so there's no risk of XSS
- Do not send raw exception messages in error handlers - Replace var with const for immutable variables - Simplify conditional assignments using ternary operators - Replace array loops with map() for cleaner code - Standardize error responses using res.status().send() pattern - Add clarifying comments for message routing logic - Simplify 404 handler with template literals
dwickr
force-pushed
the
minor-cleanup
branch
from
February 10, 2026 13:36
1c5af7c to
880173a
Compare
dwickr
changed the title
bhrju
reviewed
Feb 10, 2026
bhrju
reviewed
Feb 10, 2026
bhrju
reviewed
Feb 10, 2026
bhrju
reviewed
Feb 10, 2026
bhrju
approved these changes
Feb 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
res.status().send()pattern