Skip to content

fix: use unique file name for staging to avoid file name collision #100

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zzbrar merged 1 commit into from
Sep 30, 2026
Merged

fix: use unique file name for staging to avoid file name collision #100

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 5 additions & 12 deletions src/web_interface.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -408,24 +408,17 @@ async function main(): Promise<void> {
console.log('attachment is not defined!')
return res.status(400).send('No attachment included in request')
} else {
// multer/busboy should provide only the basename of the file, but call
// path.basename again to be certain there's no chance of path traversal
// Send the file from multer's unique, randomly-named staging path
// otherwise can cause name collision race condition
const filename = path.basename(req.file.originalname)
const userNewFile = path.join(userAttachmentsDir, filename)
const inFile = path.join(userAttachmentsDir, req.file.filename)

if (fs.existsSync(userNewFile)) {
fs.unlinkSync(userNewFile)
}

fs.renameSync(inFile, userNewFile)
console.log({ inFile, userNewFile }, 'Sending attachment')
console.log({ inFile }, 'Sending attachment')

if (body.vgroupid) {
try {
const csra = await WickrIOAPI.cmdSendRoomAttachment(
body.vgroupid,
userNewFile,
inFile,
filename,
ttl,
bor
Expand All @@ -450,7 +443,7 @@ async function main(): Promise<void> {
try {
const reply = await WickrIOAPI.cmdSend1to1Attachment(
users,
userNewFile,
inFile,
filename,
ttl,
bor
Expand Down
Loading