Repository navigation
fix: pass messageID so that 1:1 attachments aren't dropped from reporting - #41
Merged
Merged
Conversation
dwickr
previously approved these changes
Oct 1, 2026
| } | ||
|
|
||
| async cmdSend1to1Attachment(users, attachment, displayName, ttl, bor, messageMetaData, deleteWhenSent, isLowPriority) { | ||
| async cmdSend1to1Attachment(users, attachment, displayName, ttl, bor, messageMetaData, deleteWhenSent, isLowPriority, messageID) { |
Contributor
There was a problem hiding this comment.
We should probably add some tests cases to https://github.com/WickrInc/wickrio_addon/blob/master/test/spec/test-definitions.yaml for this
Contributor
Author
There was a problem hiding this comment.
Word, I didnt even see that spec, will follow-up on that
bhrju
previously approved these changes
Oct 1, 2026
dwickr
approved these changes
Oct 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Without messageID being passed through here, it wont be reported when /status or /report is called for broadcast bot. Optional to be backwards compatible
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.