report-processor uses an unholy mix of promises and callbacks

[ottumm]

processReport takes a callback but calls it from within a promise. This can lead to race conditions and generally difficult-to-follow behavior. processReport should implement a promise interface instead.

[briangreenery]

It would take some refactoring, but here's what it seems like that file is doing and how functionality could be shifted around to possibly make the file more holy.

var parseReport = require('./report-parser.js');
var _ = require('lodash');

function getStatus(report) {
  if (report.bulkAggregates === undefined) {
    return 'unknown';
  }

  if (report.bulkAggregates.max === 0) {
    return 'failed';
  }

  return 'ok';
}

function addReport(doc, db, webHooks) {
  if (doc.monitors_id) {
    db.updateMonitorStatus(doc.monitors_id, doc.status);
  }

  return db.insertReport(doc)
    .then(function() {
      if (doc.owner) {
        webHooks.send(doc.owner, doc.report);
      }
    });
}

function processReport(doc, db, webHooks) {
  doc = _.clone(doc);
  doc.report = parseReport(doc.content);
  doc.status = getStatus(doc.report);

  if (doc.report.uuid === undefined) {
    throw new Error('Invalid report: missing UUID');
  }

  return db.getOrCreateMonitor(doc.report.uuid)
    .then(function(id) {
      doc.monitors_id = id;
      return addReport(doc, db, webHooks);
    });
}

module.exports = processReport;