Skip to content

Shp 229/mobile layout and font consistency - #174

Merged
Bralc003 merged 23 commits into
devfrom
shp-229/mobile-layout-and-font-consistancy
May 25, 2026
Merged

Shp 229/mobile layout and font consistency#174
Bralc003 merged 23 commits into
devfrom
shp-229/mobile-layout-and-font-consistancy

Conversation

@Bralc003

Copy link
Copy Markdown
Collaborator

Minor fixes to Mobile Layout and Fonts to make all pages consistent. Remove unused imports, variables, and fix all front end warnings.

  • All pages should now use the font header font styling from the theme provider.
  • Font size will become smaller when viewing in a mobile view.
  • Removed all unused imports and variables in front end files.
  • Updated useEffect functions inside files such as MerchantReport and UserManagementTable to use callback to fix the dependency warnings. Basically this makes it so the function only needs to run again if there is a change in one of the dependencies in the function.
  • There should be no warnings in the terminal when you run the application now

Generally these changes should make the front end look more consistent and remove all the warnings when running the application.

@Bralc003
Bralc003 requested a review from jshudbrd May 24, 2026 06:41

@jshudbrd jshudbrd left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! most of the pages feel consistent and responsive. Only page that needs fixing is the RequestPatientAccess route. Just needs to account for the sidebar and header pixel offset when viewing on smaller screens.

besides that all good.

@Bralc003
Bralc003 requested a review from jshudbrd May 25, 2026 08:05
@Bralc003

Copy link
Copy Markdown
Collaborator Author

Should be fixed up now. Forgot to check that page

@jshudbrd jshudbrd left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@Bralc003
Bralc003 merged commit c244298 into dev May 25, 2026
1 check passed
@Bralc003
Bralc003 deleted the shp-229/mobile-layout-and-font-consistancy branch May 25, 2026 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants