Conversation
tenkus47
commented
Oct 1, 2026
- Introduced LiveRecitationPage for dedicated recitation during live events.
- Updated LiveEventDetail to link to the new recitation page and display relevant information.
- Enhanced i18n files with new keys for recitation features in English and Tibetan.
- Improved LiveViewerCount to support dark mode for the recitation page.
- Added tests for recitation functionality and viewer count integration.
- Introduced LiveRecitationPage for dedicated recitation during live events. - Updated LiveEventDetail to link to the new recitation page and display relevant information. - Enhanced i18n files with new keys for recitation features in English and Tibetan. - Improved LiveViewerCount to support dark mode for the recitation page. - Added tests for recitation functionality and viewer count integration.
|
- Added animation for the recitation pace underline in App.css. - Updated i18n files with new keys for recitation contents and settings in English and Tibetan. - Enhanced LiveRecitationPage to support theme switching between dark and light modes. - Improved LiveRecitationView to display event liturgies and manage user-selected themes. - Added tests for recitation functionality, including theme changes and liturgy selection.
- Changed the backend URL in the development environment to point to local server. - Improved mobile detection logic in the useIsMobile hook for better performance. - Added new translation keys for showing all media in group pages in English and Tibetan. - Enhanced GroupPage component to manage group addresses more effectively, including handling private groups. - Updated GroupPosts component to allow expansion of media items with a button for better user experience. - Added tests to ensure correct behavior of group address handling and media display.
| backgroundPosition: "0 100%", | ||
| backgroundSize: "0% 2px", | ||
| paddingBottom: "0.12em", | ||
| animation: `recitation-pace ${timing.durationMs}ms linear ${timing.delayMs}ms both`, |
There was a problem hiding this comment.
Live text ignores reduced motion
When a reader asks their device to reduce motion, the live line still runs the sweeping underline and one-second color fade. The scroll already honors that choice, but these animations do not. Stop or shorten them for readers who request less motion.
Prompt To Fix With AI
This is a comment left during a code review.
Path: src/routes/live-events/components/RecitationVerse.tsx
Line: 38
Comment:
**Live text ignores reduced motion**
When a reader asks their device to reduce motion, the live line still runs the sweeping underline and one-second color fade. The scroll already honors that choice, but these animations do not. Stop or shorten them for readers who request less motion.
---
For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
| <button | ||
| key={item.id} | ||
| type="button" | ||
| onClick={() => setExpanded(true)} |
There was a problem hiding this comment.
Click handler lacks required name
The new media button uses an unnamed inline click function. The repository requires event functions to have descriptive names starting with handle. Name this handler before merging; the same pattern appears in the new recitation controls.
Context Used: .cursor/rules/pecha-cursor-rule.mdc (source)
Prompt To Fix With AI
This is a comment left during a code review.
Path: src/routes/groups/components/GroupPosts.tsx
Line: 55
Comment:
**Click handler lacks required name**
The new media button uses an unnamed inline click function. The repository requires event functions to have descriptive names starting with `handle`. Name this handler before merging; the same pattern appears in the new recitation controls.
**Context Used:** .cursor/rules/pecha-cursor-rule.mdc ([source](https://github.com/webuddhist-tech/webuddhist/blob/develop/.cursor/rules/pecha-cursor-rule.mdc))
---
For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.- Replaced the recitation pace underline with a glow effect for the live line in App.css. - Updated LiveRecitationView to implement glow animations for recited text, enhancing visual feedback. - Changed utility functions to use line timings instead of run timings for better accuracy in recitation pacing. - Adjusted tests to reflect changes in glow behavior and timing logic for recitation lines. - Improved RecitationVerse component to manage glow effects based on the room's pace.
…ive recitation features - Changed the backend URL in the development environment to point to the production server. - Deleted unused image assets including logos and icons to streamline the project. - Updated i18n files with new keys for Google sign-in and improved user prompts in English and Tibetan. - Enhanced LiveRecitationPage and LiveRecitationView to better manage event titles and user interactions. - Improved tests for LiveRecitationPage to ensure accurate rendering and functionality.
- Updated index.html to handle iPadOS detection and improve app linking for Android users, ensuring proper redirection to the app store if the app is not installed. - Added CSS rules to prevent overscroll behavior in the sidebar shell, enhancing the user experience on mobile devices. - Introduced new routes in App.tsx for the OpenApp component, allowing better navigation for users attempting to access the app. - Updated i18n files to include new translation keys for improved user prompts in English and Tibetan. - Refactored GroupPage to streamline the display of group types and improve the overall layout. - Enhanced tests for GroupPage and Home components to ensure accurate rendering and functionality.
- Introduced a new Tolgee plugin for managing translations from a CDN with local fallback, enhancing the localization experience. - Updated the AppOpenBanner component to utilize translations for titles and descriptions, improving accessibility. - Refactored the AppFooter to support dynamic translations for footer links, ensuring consistency across languages. - Enhanced various components to utilize translation keys for better internationalization support, including group titles and descriptions. - Updated i18n files with new keys for improved user prompts in English and Tibetan, enriching the user experience.
…d tests - Deleted MainLayout and NoFooterLayout components to streamline the layout structure. - Removed Footer component and its tests to eliminate redundancy and improve code maintainability. - Cleaned up related test files for Footer and NavigationBar to ensure a more focused test suite.
…er experience - Updated App.tsx to replace NoFooterLayout with SidebarLayout for full-height readers, enhancing layout consistency. - Refactored SidebarLayout to conditionally render the footer based on the reader prop, optimizing space usage. - Adjusted Chapters component to ensure proper height management for better display. - Enhanced AppFooter to utilize a centralized FOOTER_LINKS array for dynamic link rendering, improving maintainability. - Updated navigation items to support additional active paths, streamlining user navigation across related sections.
- Added WORKER environment variable to Dockerfile for the Worker API URL. - Updated Nginx configuration to handle requests to the Worker API, allowing for segment AI chat functionality. - Modified Vite configuration to route requests to the Worker API. - Updated development and production environment files to include the new WORKER_URL variable. - Added new translations for segment chat features in English. - Implemented UI changes in Resources component to open AI chat for selected segments.
Enhance Docker and Nginx configuration for Worker API integration
- Added new translation keys for segment chat features in Tibetan and updated existing English translations for consistency. - Introduced a custom hook, `useChatTranslate`, to manage translations for segment chat, allowing fallback to local i18n files. - Enhanced the `SegmentChatView` component to utilize the new translation hook and improve source citation handling. - Updated tests for the `useChatTranslate` hook to ensure proper functionality across languages and fallback mechanisms. - Improved UI interactions for displaying sources and citations in the segment chat.
Implement segment chat translation and UI enhancements
- Updated footer links to include "Team" and changed "Sherab" to "Academy". - Added a new Team page with sections for each working group and their members. - Implemented tests for the Team page to ensure proper rendering of titles, descriptions, and member details. - Introduced a JSON file to manage team data, including names, roles, and images for each member. - Enhanced accessibility by ensuring proper aria attributes are set for sections and headings.
|
❌ The last analysis has failed. |