-
Notifications
You must be signed in to change notification settings - Fork 3
Create simple Angular example app with WebMCP #10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create simple Angular example app with WebMCP #10
Conversation
|
@MiguelsPizza I've opened a new pull request, #11, to work on those changes. Once the pull request is ready, I'll request review from you. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
angular/angular.json
Outdated
| "polyfills": ["zone.js"], | ||
| "tsConfig": "tsconfig.app.json", | ||
| "inlineStyleLanguage": "css", | ||
| "assets": ["{ \"glob\": \"**/*\", \"input\": \"public\" }"], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Correct assets entry so Angular builds
The assets array currently contains a single string "{ \"glob\": \"**/*\", \"input\": \"public\" }" instead of an asset object or a real path. Angular treats string entries as literal file paths, so ng build/ng serve will try to copy that path and fail because there is no public directory anywhere in angular (checked with rg "public" angular). Use an asset object (e.g., { "glob": "**/*", "input": "public", "output": "/" }) or point to an existing folder to keep the example buildable.
Useful? React with 👍 / 👎.
Introduces the first Angular example demonstrating WebMCP integration: - Note-taking app with 6 AI-callable tools (add, delete, list, search, toggle pin, stats) - Angular 19 with standalone components and signals - WebMCP service pattern for tool registration with automatic cleanup - Reactive state management using Angular signals - Full TypeScript strict mode support The example follows the same structure as vanilla and react examples, using the modern @mcp-b/global package for tool registration.
- Simplify JSDoc comments to be concise and useful - Remove unused type imports and definitions - Add descriptive header comment to WebMCPService explaining key patterns - Consolidate verbose multi-line comments into single-line format - Remove redundant console.log statements
d27cc54 to
a959837
Compare
Introduces the first Angular example demonstrating WebMCP integration:
The example follows the same structure as vanilla and react examples, using the modern @mcp-b/global package for tool registration.
Description
Type of Change
Related Issues
Fixes #
Related to #
Changes Made
New Example Details
Testing
Commands Run
Manual Testing with MCP-B Extension
Screenshot/Demo
Checklist
@mcp-b/globalor@mcp-b/react-webmcp)/relegatedDocumentation
Additional Notes
For AI Agents: Please verify all items in the checklist before submitting. Run all commands listed in the Testing section.