Support (module definition ...) constructs - #2829
Open
zherczeg wants to merge 1 commit into
Open
Conversation
Member
|
Does this replace #2666? Is it an alternative implementation? |
sbc100
reviewed
Aug 19, 2026
| class TextScriptModule : public ScriptModuleMixin<ScriptModuleType::Text> { | ||
| public: | ||
| const Location& location() const override { return module.loc; } | ||
| bool IsDefinition() const override { return is_definition; } |
Member
There was a problem hiding this comment.
Any reason to just just make is_definition a public field on ScriptModule? i.e. do we need to use a virtual method here?
Collaborator
Author
There was a problem hiding this comment.
No. I will change this.
Collaborator
Author
There was a problem hiding this comment.
The code is even simpler this way.
sbc100
reviewed
Aug 19, 2026
sbc100
left a comment
sbc100
left a comment
Member
There was a problem hiding this comment.
Nice! A surprisingly small patch to make this work.
sbc100
approved these changes
Aug 19, 2026
Collaborator
Author
|
Yes this is a replacement. |
sbc100
approved these changes
Aug 19, 2026
| @@ -1,4 +1,4 @@ | |||
| /* C++ code produced by gperf version 3.2.1 */ | |||
| /* C++ code produced by gperf version 3.3 */ | |||
Member
There was a problem hiding this comment.
I guess we do not pin the exact version that we use here?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related patch: #2666